IRC logs of #tryton for Friday, 2008-07-25

chat.freenode.net #tryton log beginning Fri Jul 25 00:00:02 CEST 2008
2008-07-25 05:28 -!- beta_max(i=betamax@gateway/tor/x-589dba96ca2cb922) has joined #tryton
2008-07-25 08:01 -!- Timitos(n=Timitos@88.217.184.172) has joined #tryton
2008-07-25 08:23 <CIA-53> tryton: Timitos roundup * #212/Re-Open Journals - Periods seems not to work: [new] I closed and reopened a period. Then I noticed that all Journals-Periods of this period where still closed. Then I tried to reopen a journal ...
2008-07-25 08:33 <CIA-53> tryton: Timitos roundup * #213/Bank Statements inverted: [new] when entering statements debit and credit are inverted. for expample: for a negative value (company is paying) bank account must have value ...
2008-07-25 08:34 <CIA-53> tryton: Timitos roundup * #214/IndexError: list index out of range: [new] Traceback (most recent call last): File "/tryton/gui/window/view_form/view/form_gtk/many2many.py", line 105, in _sig_remove self.scree ...
2008-07-25 08:37 <CIA-53> tryton: Timitos roundup * #214/IndexError: list index out of range: [chatting] this error occurs if i click on "remove" in many2many-widget without selecting a record before. perhaps the behavior could be changed ...
2008-07-25 08:40 <CIA-53> tryton: Timitos roundup * #215/tax computation of invoice and purchase is different: [new] perhaps rounding is not optimized in purchase module
2008-07-25 08:53 <CIA-53> tryton: Timitos roundup * #216/cannot add line in purchase in existing and updated database: [new] cursor jumps to product field if i try to add a purchase line, but there is no error and no line is created. i added a backup of my db
2008-07-25 08:57 -!- cedk(n=ced@gentoo/developer/cedk) has joined #tryton
2008-07-25 09:28 <FWiesing> cedk: I update my system - now it works
2008-07-25 09:30 <cedk> FWiesing: ok you can close the issue
2008-07-25 09:30 <FWiesing> OK
2008-07-25 09:59 -!- bechamel(n=user@user-85-201-14-207.tvcablenet.be) has joined #tryton
2008-07-25 10:10 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 159:2ec5a0a6a0b6 account/journal.py: Fix re-open journal-period for issue212
2008-07-25 10:10 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 160:7c17d73057dc account/: merge
2008-07-25 10:10 <CIA-53> tryton: ced roundup * #212/Re-Open Journals - Periods seems not to work: [resolved] Fix with changeset 2ec5a0a6a0b6
2008-07-25 10:18 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 45:2e6141f89399 account_statement/statement.py: Invert debit/credit in statement for issue213
2008-07-25 10:19 <CIA-53> tryton: ced roundup * #213/Bank Statements inverted: [resolved] Fix with changeset 2e6141f89399
2008-07-25 10:20 <cedk> bechamel: why objects in account_statement are named statement.xxx instead of account.xxx ?
2008-07-25 10:26 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 556:f1bc9c2efd2f tryton/tryton/gui/window/view_form/screen/screen.py: Fix screen remove when there is no row selected for issue214
2008-07-25 10:27 <CIA-53> tryton: ced roundup * #214/IndexError: list index out of range: Fix with changeset f1bc9c2efd2f I don't make it to remove the only record if there is only one, and don't like to have this kind of implicit behavior.
2008-07-25 10:43 <CIA-53> tryton: htgoebel roundup * #193/printing as pdf fails: This is obviously a problem of your OpenOffce.org or openoffice.interact installation. As I'm the developer of both openoffice.interact and tryto ...
2008-07-25 10:46 <bechamel> cedk: it's an error
2008-07-25 10:46 <cedk> bechamel: ok I will fix
2008-07-25 10:51 <CIA-53> tryton: htgoebel roundup * #193/printing as pdf fails: [resolved] since this is a problem of openoffice.interact, I'll close this issue fpor tryton. Reporter: If you find any problems, please report t ...
2008-07-25 10:55 -!- kultviech(n=kultviec@p5B0D2467.dip0.t-ipconnect.de) has joined #tryton
2008-07-25 10:56 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 7:d17a08331453 analytic_invoice/invoice.xml: Use name analytic_accounts for group
2008-07-25 10:56 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 8:fd0292fbc198 analytic_invoice/invoice.py:
2008-07-25 10:56 <CIA-53> tryton: Remove required on analytic_accounts
2008-07-25 10:56 <CIA-53> tryton: Fix interger ids for write/unlink
2008-07-25 10:56 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 7:5ed929f0ed36 analytic_purchase/purchase.py:
2008-07-25 10:56 <CIA-53> tryton: Remove required on analytic_accounts for issue216
2008-07-25 10:56 <CIA-53> tryton: Fix integer ids in write/unlink
2008-07-25 10:58 <CIA-53> tryton: ced roundup * #216/cannot add line in purchase in existing and updated database: [resolved] Fix with changeset 5ed929f0ed36 I drop the not null constraints on analytic_accounts so you must update your database manually.
2008-07-25 11:13 <cedk> Timitos: ping
2008-07-25 11:19 <cedk> for issue215 I find the problem
2008-07-25 11:19 <cedk> but I don't know which solution is right
2008-07-25 11:20 <cedk> on the purchase we round the result of the computation of taxes on each purchase lines and once globaly
2008-07-25 11:20 <cedk> on the invoice we round only once globaly
2008-07-25 11:21 <cedk> so what do you think guys?
2008-07-25 11:27 <cedk> I think I will round on each line because we need to write the tax amount of each line in the accounting for tax report
2008-07-25 11:30 <cedk> but so what we have is tax: 7%, base: 700, amout: 48.97
2008-07-25 11:30 <cedk> is it a problem?
2008-07-25 11:33 <cedk> bechamel: ping
2008-07-25 11:43 <bechamel> cedk: i was always told that each line must be rounded
2008-07-25 11:50 <bechamel> cedk: iirc, on a legal point of view both are ok, isn't it ?
2008-07-25 11:51 <cedk> bechamel: yes but it can be strange to have the line above 7% 700 48.97
2008-07-25 11:52 <bechamel> cedk: and also the way the rouding is made is also ok (as long as there is less than one cent of difference)
2008-07-25 11:52 <cedk> because it is different from 0.03
2008-07-25 11:52 <cedk> or 0.02
2008-07-25 11:53 <cedk> it is because we have rounding 12 lines so 12 * 0.005 =0.06
2008-07-25 11:54 <cedk> these is the maximum error we can have
2008-07-25 11:54 <bechamel> cedk: one can imagine rouding each line _and_ rounding the total with respect to the non-rouded lines
2008-07-25 11:55 <cedk> but we will have difference between the amount in the account line and the amount in the tax charts
2008-07-25 11:55 <cedk> I think this is wrong
2008-07-25 11:56 <bechamel> so finaly the purchase is ok but not the invoice
2008-07-25 11:57 <cedk> the only problems that I see it is that the 48.97 is not wrong but it can look wrong, so we will have many reports about the fact that tryton doesn't compute right
2008-07-25 11:58 <cedk> yes invoice will generate amount in account line that doesn't match the amount in the tax report
2008-07-25 12:02 <cedk> so I will fix the invoice and round each lines
2008-07-25 12:03 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 80:3e47bd68dcad account_invoice/invoice.py: Round base and tax amount on each lines of invoice for issue215
2008-07-25 12:04 -!- udono(n=uspallek@kons-5d84f767.pool.einsundeins.de) has joined #tryton
2008-07-25 12:04 <CIA-53> tryton: ced roundup * #215/tax computation of invoice and purchase is different: [resolved] Fix with changeset 3e47bd68dcad
2008-07-25 12:04 <udono> hi all
2008-07-25 12:10 <FWiesing> udono: hi
2008-07-25 12:10 <udono> hi FWiesing
2008-07-25 12:16 -!- markusleist(n=markus@n4-82.dsl.vianetworks.de) has joined #tryton
2008-07-25 12:48 -!- kultviech(n=kultviec@p5B0D2467.dip0.t-ipconnect.de) has left #tryton
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 753:7f92b13001dc trytond/trytond/ (21 files in 10 dirs): Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 161:194a4266b73a account/ (8 files): Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 81:9405bb22f675 account_invoice/ (invoice.py invoice.xml): Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 46:7f9a12af2139 account_statement/ (journal.xml statement.py statement.xml): Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 14:b8a7e7456c1a analytic_account/account.xml: Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 9:0cbe18714397 analytic_invoice/invoice.py: Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 8:0bd3690ce4d0 analytic_purchase/purchase.py: Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 10:392150302682 currency/currency.xml: Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 62:00b7bf83fbfe product/ (category.xml product.xml uom.xml): Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 9:0cdba91dfda0 project/work.xml: Change unlink to delete for issue201
2008-07-25 12:52 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 46:acbee1d25f29 purchase/purchase.xml: Change unlink to delete for issue201
2008-07-25 12:53 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 112:d479bd1b4b50 relationship/ (category.xml country.xml party.xml): Change unlink to delete for issue201
2008-07-25 12:53 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 171:ac1b67337f0f stock/ (location.xml move.py packing.py): Change unlink to delete for issue201
2008-07-25 12:53 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 36:3ff5b7cdd34e timesheet/work.xml: Change unlink to delete for issue201
2008-07-25 12:53 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 557:a5a9b4b18871 tryton/tryton/gui/window/ (7 files in 3 dirs): Change unlink to delete for issue201
2008-07-25 12:53 <CIA-53> tryton: ced roundup * #201/Change unlink to delete in the kernel: [resolved] Fixed
2008-07-25 13:23 <Timitos> cedk: i am here only for a short while
2008-07-25 13:24 <Timitos> cedk: your solution for purchase and invoice computing of tax is not correct in my eyes.
2008-07-25 13:24 <Timitos> i would have prefered exactly the other way.
2008-07-25 13:24 <Timitos> perhaps we should discuss the computation of tax over tax codes too.
2008-07-25 13:25 <Timitos> perhaps it would be better to find another solution for computation of tax for tax report.
2008-07-25 13:25 <Timitos> the solution you choosed will not fit to the needs of our customers.
2008-07-25 13:27 -!- kultviech(n=kultviec@p549779BB.dip.t-dialin.net) has joined #tryton
2008-07-25 13:33 <Timitos> cedk: will be back later in the evening
2008-07-25 13:33 <bechamel> Timitos, cedk : one can imagine that the rouding on the lines take care of the total rouding, ie force rounding above or under to match the total rouding. I think i's legal (but this will look funny if the price tax included are printed for each line)
2008-07-25 13:36 <Timitos> bechamel: i think price tax included for each line is not important. but there are some questions we need to discuss.
2008-07-25 13:37 <Timitos> bechamel: i think for tax computation the net sum of all positions of an invoice with the same tax are the base for tax computation. i think we need to see an invoice as one entity for tax computation and not the lines of an invoice.
2008-07-25 13:39 <Timitos> the other point is that we will always have few differences. i need to search for the correct way to do the tax report query. this will be important if we switch back to the computation method of the invoice before the today change of cedk
2008-07-25 14:01 <cedk> Timitos: What is wrong with the solution?
2008-07-25 14:02 <cedk> Timitos: you are allowed to round tax on lines
2008-07-25 14:03 <Timitos> cedk: you wrote: the only problems that I see it is that the 48.97 is not wrong but it can look wrong, so we will have many reports about the fact that tryton doesn't compute right
2008-07-25 14:03 <cedk> Timitos: any store works like that
2008-07-25 14:03 <cedk> Timitos: yes it is not wrong
2008-07-25 14:04 <Timitos> cedk: and there must be a way to prevent this.
2008-07-25 14:04 <Timitos> yes. but this way you won´t get any customer for tryton in germany.
2008-07-25 14:04 <cedk> Timitos: yes not put together all invoice line tax
2008-07-25 14:05 <cedk> Timitos: why? Is it illegal in germany to round on line
2008-07-25 14:07 <Timitos> for me it is only important that i get an invoice with 700 749 and not 700 748,97. the kind of solution is for me not so important.
2008-07-25 14:07 <Timitos> but as I see the german law you must see all lines of an invoice as one action and tax is computed from this one action and not from lines. but i need to talk about this with a tax advisor
2008-07-25 14:09 <cedk> Timitos: so you will have different tax amount if you have one invoice with many lines or many invoice with one lin
2008-07-25 14:10 <Timitos> cedk: why?
2008-07-25 14:10 <cedk> Timitos: because of rounding
2008-07-25 14:11 <Timitos> if i sum up the net prices and compute the tax value from this sum? i don´t think so.
2008-07-25 14:11 <cedk> Timitos: if you have one invoice with 10 lines or 10 invoice with 1 lines, you will have different tax amount
2008-07-25 14:12 <cedk> Timitos: because grouping lines increase the precision of the computation
2008-07-25 14:13 <cedk> so for me there is not one good solution, there is two possibilities wich have pro and cons
2008-07-25 14:13 <cedk> and if you want to have tax line accounting on the account lines, you must round on lines
2008-07-25 14:16 <Timitos> cedk: i have to leave now as i am to late for about 30 minutes to my appointment just in the moment. can we continue this discussion in the evening or tomorrow?
2008-07-25 14:16 <cedk> Timitos: yes
2008-07-25 14:16 <Timitos> cedk: ok. i will ping you in the evening perhaps.
2008-07-25 15:13 -!- Gedd(n=ged@77.109.115.121) has joined #tryton
2008-07-25 15:48 -!- FWiesing(n=Wiesinge@194.208.185.12) has left #tryton
2008-07-25 16:15 <udono> cedk: about the rounding: If you round each line single, than you cummulate the rounding-error. And you are right, if there are a lot of lines, the roundingerror is rising high. In Germany its - afaik- usual to have just one cent differences by roundings. Withe the rounding like in purchase, there can cummulate more than one cent. The best way is to sum up all amounts with all possible significance and round this sum at last. There is no
2008-07-25 16:15 <udono> ed to round each line in Belgique, than you have to carry the rounding error from each line to the next line, and so on... In the german article about rounding is this discribed: http://de.wikipedia.org/wiki/Rundung#Summenerhaltendes_Runden but there is no english article about this...
2008-07-25 16:17 -!- FWiesing(n=Wiesinge@194.208.185.12) has joined #tryton
2008-07-25 16:17 <cedk> udono: I was thinking about that, and in fact there is no problem for report to not round at each lines
2008-07-25 16:17 <Timitos> cedk: +1
2008-07-25 16:18 <cedk> so i fix the purchase to not compute taxes by rounding on each lines
2008-07-25 16:18 <Timitos> cedk: i just checked this. i think it is the best solution not to round at each line but at the end
2008-07-25 16:18 <Timitos> cedk: +1
2008-07-25 16:19 <Timitos> cedk: i think you need to revert your changes to invoice too ,or not?
2008-07-25 16:20 <udono> cedk: which precision does our amount have?
2008-07-25 16:21 <cedk> udono: it is Decimal object
2008-07-25 16:23 <udono> cedk: does it mean it is as exact as the computer can calculate?
2008-07-25 16:23 <cedk> udono: yes it is not float
2008-07-25 16:23 <cedk> udono: it makes compute like you do by hand :-)
2008-07-25 16:24 <cedk> udono: it is standard to use Decimal for currency
2008-07-25 16:24 <cedk> udono: and it is also recommended in the python doc
2008-07-25 16:25 -!- Timitos(n=Timitos@88.217.184.172) has joined #tryton
2008-07-25 16:26 <cedk> udono: and that why we don't have to care to not round at each lines
2008-07-25 16:26 <cedk> udono: if it was in float, that can create errors
2008-07-25 16:27 <udono> cedk: good design decision!
2008-07-25 16:29 <udono> cedk: so we dont have to worry about if we create in future a module for tax included pricings for the b2c market. With a fine precision there wont come up a rounding problem, too.
2008-07-25 16:30 <cedk> udono: I know this problem, I worked for a company that makes software for bank (in COBOL :-))
2008-07-25 16:30 <cedk> udono: no for tax included it will always have rounding problem
2008-07-25 16:31 <cedk> udono: but we have some thoughts about how to make a kind of POS that will work
2008-07-25 16:32 <udono> cedk: the standard rounding error in calculate the netprice is no problem, because it is impossible to calculate exact...
2008-07-25 16:32 <udono> cedk: problem is just if we are more unexact than this rounding-error...
2008-07-25 16:33 <udono> Bye guys, Iam traveling back home now, see you on monday...
2008-07-25 16:33 <cedk> udono: http://docs.python.org/lib/module-decimal.html
2008-07-25 16:34 <udono> cedk: I know this module, it has all the stuff, bookeepers need for calculating amounts.
2008-07-25 16:38 <Timitos> udono: cu
2008-07-25 16:38 <udono> Timitos: cu
2008-07-25 16:52 <cedk> I push the fix, but CIA seems to be down
2008-07-25 16:53 <Timitos> cedk: thx. i will test.
2008-07-25 17:07 -!- Timitos(n=Timitos@88.217.184.172) has joined #tryton
2008-07-25 18:01 -!- beta_max(i=betamax@gateway/tor/x-ab2f0062204bd053) has joined #tryton
2008-07-25 18:04 <cedk> is someone find a real improvement with psyco module?
2008-07-25 18:05 <Timitos> cedk: what shall we look for?
2008-07-25 18:08 <bechamel> cedk: i tried psycho several month ago and it was a matter of 10 or 15% improvement
2008-07-25 18:08 <cedk> Timitos: it is a module that add somethings like JIT compiler
2008-07-25 18:08 <cedk> I add in tryton the import if the module is there
2008-07-25 18:09 <Timitos> cedk: so i should try to install the module on my server?
2008-07-25 18:09 <cedk> the doc says that it can improve speed 10x to 100x
2008-07-25 18:10 <cedk> I don't find any instability with it
2008-07-25 18:10 <cedk> just it doesn't work with pax MPROTECT but that is not really a problem
2008-07-25 18:11 <Timitos> bechamel: i can´t enter a bank statement with the new solution. something is wrong with the statement.journal but i don´t know what. there is no error message.
2008-07-25 18:12 <Timitos> cedk: i will install it on my testserver
2008-07-25 18:15 <cedk> Timitos: it increase the memory usage
2008-07-25 18:15 <Timitos> cedk: ok. this should not be a problem for my installation
2008-07-25 18:16 <cedk> Timitos: and not for tryton because it depends of the size of the code
2008-07-25 18:16 <cedk> and tryton doesn't have soo much code
2008-07-25 18:17 <Timitos> cedk: there is really some speed improvement with this module.
2008-07-25 18:19 <cedk> Timitos: on my dual core, I don't see much difference
2008-07-25 18:21 <Timitos> cedk: no not much. my server is a vm.
2008-07-25 18:21 <Timitos> i think the value of bechamel 10-15% is quite near
2008-07-25 18:23 <bechamel> cedk: if you want to check you can try simply with "print time.clock()"
2008-07-25 18:23 <cedk> bechamel: it is not a real test, because it compile python function
2008-07-25 18:24 <cedk> bechamel: so in tryton, we have many function and some are often called
2008-07-25 18:24 <bechamel> cedk: and ?
2008-07-25 18:27 <cedk> bechamel: there will be more improvement than just the call of clock
2008-07-25 18:29 <bechamel> cedk: i hope :), to test you have to put print time.clock() at several places. e.g. at the beginning and at the end of a big function and check the time spent between
2008-07-25 18:30 <bechamel> cedk: pyscopg generate this: ALTER TABLE E'ir_ui_menu' ADD FOREIGN KEY (E'parent') REFERE...
2008-07-25 18:31 <bechamel> cedk: and i dont understand where these "E" comes from ?!
2008-07-25 18:31 <CIA-53> tryton: Timitos roundup * #218/cannot enter bank_statement when in name of account.journal is an umlaut: [new] if the name of an account.journal has an umlaut like ä ö ü i cannot make a new bank statement. if i click on validate there is no functio ...
2008-07-25 18:31 <bechamel> cedk: i think i already saw them but i dont remember in which condition
2008-07-25 18:32 <cedk> bechamel: copy/paste the code
2008-07-25 18:32 <bechamel> http://paste.pocoo.org/show/80306/
2008-07-25 18:34 <bechamel> cedk: more complete one : http://paste.pocoo.org/show/80307/
2008-07-25 18:35 <cedk> bechamel: don't use %s for table name and put " " between
2008-07-25 18:35 <cedk> bechamel: and the same for FOREIGN KEY
2008-07-25 18:36 <cedk> bechamel: and also for ON DELETE
2008-07-25 18:36 <cedk> Timitos: You don't have traceback for issue218?
2008-07-25 18:39 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 47:72e820339786 account_statement/ (journal.py journal.xml statement.py statement.xml): Use account as first name for object and fix some guidelines
2008-07-25 18:40 <cedk> Timitos: by the way I just push a change of name for all the module account_statement
2008-07-25 18:40 <cedk> Timitos: so you will not be able to use your current DB
2008-07-25 18:40 <Timitos> cedk: sorry. there is no traceback. but i am a litte bit confused now. it is working now and i don´t know why :-)
2008-07-25 18:41 <Timitos> cedk: ok
2008-07-25 18:41 <bechamel> cedk: you mean "ALTER ... " + table_name + " ADD .." ?
2008-07-25 18:41 <cedk> bechamel: yes
2008-07-25 18:41 <cedk> bechamel: there is no problem of sql injection as table_name comes from code
2008-07-25 18:41 <bechamel> cedk: yes
2008-07-25 18:42 <cedk> bechamel: %s is for formating values not any string in the query
2008-07-25 18:57 <CIA-53> tryton: Timitos roundup * #218/cannot enter bank_statement when in name of account.journal is an umlaut: [resolved] i close this issue as it is working now. i could not reproduce the error
2008-07-25 22:09 -!- CIA-54(n=CIA@208.69.182.149.simpli.biz) has joined #tryton
2008-07-25 22:48 -!- betamax_(i=betamax@gateway/tor/x-1915eabf6bd06d9b) has joined #tryton
2008-07-25 22:53 -!- kultviech(n=kultviec@p5B0D2467.dip0.t-ipconnect.de) has joined #tryton

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!