IRC logs of #tryton for Monday, 2010-08-02

chat.freenode.net #tryton log beginning Mon Aug 2 00:00:02 CEST 2010
-!- digitalsatori(~tony@116.233.249.147) has joined #tryton00:36
-!- gremly(~gremly@201.244.193.238) has joined #tryton03:01
-!- digitalsatori(~tony@116.233.249.147) has joined #tryton04:12
-!- mr_amit(~amit@117.254.179.209) has joined #tryton07:01
-!- Timitos(~timitos@88.217.184.172) has joined #tryton08:42
-!- enlightx(~enlightx@62-207.203-62.cust.bluewin.ch) has joined #tryton09:04
-!- tekoholic(~quassel@184-96-85-143.hlrn.qwest.net) has joined #tryton09:48
-!- MikaelPettersson(~chatzilla@host191-12.bornet.net) has joined #tryton10:02
-!- essich(~essich@p4FCF92F9.dip0.t-ipconnect.de) has joined #tryton11:05
-!- cedk(~cedk@gentoo/developer/cedk) has joined #tryton11:41
-!- mr_amit(~amit@117.254.22.125) has joined #tryton12:19
-!- paepke(~paepke@p4FEB0F6E.dip0.t-ipconnect.de) has joined #tryton12:29
-!- MikaelP(~chatzilla@cust-IP-11.data.tre.se) has joined #tryton12:33
-!- gremly(~gremly@201.244.193.238) has joined #tryton13:19
-!- gremly(~gremly@201.244.193.238) has joined #tryton13:20
-!- gremly(~gremly@201.244.193.238) has joined #tryton13:30
-!- gremly(~gremly@201.244.193.238) has joined #tryton13:32
-!- enlightx(~enlightx@62-207.203-62.cust.bluewin.ch) has joined #tryton13:41
-!- pheller(~pheller@pool-173-48-216-195.bstnma.fios.verizon.net) has joined #tryton14:10
-!- MikaelPettersson(~chatzilla@cust-IP-11.data.tre.se) has joined #tryton14:19
-!- digitalsatori(~tony@116.233.249.147) has joined #tryton14:32
-!- pheller(~pheller@c1fw226.constantcontact.com) has joined #tryton14:47
-!- bechamel(~user@host-85-201-159-186.brutele.be) has joined #tryton15:09
-!- pepeu(~manuel@201.155.193.192) has joined #tryton15:56
-!- woakas(~woakas@pcsp163-59.supercabletv.net.co) has joined #tryton16:22
-!- tekknokrat(~lila@188.106.99.200) has joined #tryton16:36
-!- pepeu(~manuel@201.155.193.192) has joined #tryton16:53
-!- plantian(~ian@c-69-181-194-95.hsd1.ca.comcast.net) has joined #tryton17:21
phelleranyone around that can answer a question re: converting modules for the transaction system?17:22
Timitospheller: maybe i can help you17:30
phellerso I am converting Company.....17:30
phellersee here17:31
phellerhttp://codereview.appspot.com/1853047/diff/10001/1100217:31
phellerline 281 and 291....17:31
phellerso I know I must include "localcontext=None" in the function signature17:31
pheller... and that I must pass localcontext=localcontext in the call to super(...) in each function....17:32
phellerand according to ced in the most recent comment, I must instead set the values in localcontext.  so, for the company report, localcontext['company'] = user.company.id17:32
phellerno problem.... but, in the LetterReport, it doesn't make sense to do this ... because user is already set exactly like this in the localcontext of the "Report" class (from which LetterReport inherits)17:33
Timitospheller: i think you are right. looks like it is not necessary. the behavior of the parse method changed a little bit.17:45
phellerRight, so if it is unnecessary for the LetterReport, then almost everything for the LetterReport is unnecessary, except maybe the _name, so that everything continues to work....17:47
Timitoscedk: because of this line http://hg.tryton.org/hgwebdir.cgi/1.6/trytond/file/aac47c8adb68/trytond/report/report.py#l149 it was possible to update the user in localcontext to a value set in context. this is no more possible in trunk.17:48
Timitoscedk: do you see problems with this?17:48
Timitoscedk: i must correct. it is no more possible with trunk + transaction patch17:50
Timitospheller: you are right. if it is like we think only the _name needs to stay. but i think you should wait for an confirmation by cedk17:52
-!- blast_hardcheese(~blast_har@dsl092-043-124.lax1.dsl.speakeasy.net) has joined #tryton17:57
-!- juanfer(~juanfer@201.244.237.64) has joined #tryton18:06
Timitospheller: but you need to fix the signature of the parse function in any case: def parse(self, report, objects, datas, localcontext=None):18:08
phellerTimitos: yes, I understand.  I'm waiting for cedk before I submit my final patchset.18:19
phellerone more question regarding the same patchset I posted....   line 153, and 184.18:20
phellerthe indent should be 4 more spaces than the line above?  or should it be 8 more?18:20
phellerI think 184 (and 185) look right, but ced says 8 spaces?18:21
Timitospheller: 8 more spaces thant the line above18:23
phellerhuh, really.  I thought pep-008 said only 4.18:23
Timitospheller: we use 8 spaces for multiline statements18:24
phellerok, I will conform to this convention going forward then18:25
Timitospheller: there is an exception for this 8 spaces rule. when there is a multiline list you should use 4 space like here: http://hg.tryton.org/hgwebdir.cgi/modules/sale/file/7c034ebad23f/sale.py#l3318:30
Timitospheller: i hope that i explained it right as it is not yes documented.18:30
phelleryes a coding guideline document would be very helpful18:31
phellerthat last one is a little surprising, because the closing brace is at the same indent as the first column of the first line.18:31
Timitospheller: this is the only existing one: http://code.google.com/p/tryton/wiki/CodingGuidelines18:31
Timitospheller: yes. there are different versions of this in the code. i would also use 4 spaces in this case18:32
phellerit's only that the line beginning "], 'State'" in your last example isn't as easy to visually parse as if it were indented more18:33
phellerI'm amazed how quickly the module conversions have seemed to go, though18:34
phellerby my count, just over half are complete or have at least begun18:35
Timitosyes. this is great18:35
phellerI really hope the SocketServer ticket can been addressed before 1.8, so I can at least develop on my Mac once again.18:36
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton18:39
phellercedk: if you can look at the last messages between Timitos, myself, and to you --- we need your opinion on the localcontext in reports18:41
cedkpheller: I check in 5 mins18:42
phellerok, cool.  thanks18:42
cedkpheller: I agree18:53
phellerOk, so LetterReport will only contain _name....18:54
phellerand for CompanyReport, company is assigned with localcontext['company'] now.....18:55
phelleryes?18:55
cedkpheller: yes19:23
phellerok, just submitted the patchset19:25
-!- MikaelPettersson(~chatzilla@host191-12.bornet.net) has joined #tryton19:36
-!- mr_amit(~amit@117.254.22.196) has joined #tryton19:58
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton20:06
-!- tekknokrat(~lila@188.106.99.200) has joined #tryton20:23
-!- gremly(~gremly@201.244.193.238) has joined #tryton21:24
-!- paepke_(~paepke@p4FEB008E.dip0.t-ipconnect.de) has joined #tryton21:43
-!- paepke(~paepke@p4FEB008E.dip0.t-ipconnect.de) has left #tryton21:57
-!- paepke(~paepke@p5B32AFB0.dip.t-dialin.net) has joined #tryton23:48
-!- paepke(~paepke@p5B32AFB0.dip.t-dialin.net) has joined #tryton23:50

Generated by irclog2html.py 2.11.0 by Marius Gedminas - find it at mg.pov.lt!