| chat.freenode.net #tryton log beginning Mon Jul 22 00:00:06 CEST 2013 | ||
| 2013-07-22 10:31 <prakash> nicoe: i have a question related to relatorio - can i add sheets programmatically in a report ? | ||
| 2013-07-22 10:31 <prakash> nicoe: i am talking about an ods report | ||
| 2013-07-22 10:33 <nicoe> prakash: Never tried it | ||
| 2013-07-22 10:34 <nicoe> prakash: but from the top of my head I would say that you will have to edit the XML yourself and recompose the ods | ||
| 2013-07-22 10:38 <prakash> nicoe: thanks | ||
| 2013-07-22 10:38 <cedk> prakash, nicoe: I think you can just add url's in the cells | ||
| 2013-07-22 10:38 <prakash> cedk: urls ? could you explain a bit more please ? | ||
| 2013-07-22 10:39 <cedk> prakash: sorry I did not understand you wanted to add sheets | ||
| 2013-07-22 10:40 <prakash> cedk: ah! its ok, thanks for your attention. will try what nicoe said and I will update here | ||
| 2013-07-22 10:40 <nicoe> prakash: The first thing to try is to put urls in the tab names it might work (but I am not sure) | ||
| 2013-07-22 10:40 <nicoe> prakash: And if not possible then you'll have to edit the XML | ||
| 2013-07-22 10:42 <prakash> thanks nicoe, I'll try this. | ||
| 2013-07-22 11:44 <sharoonthomas> nicoe: cedk: we had a proposal sometime back about having these reports in XML form rather than the current binary version | ||
| 2013-07-22 11:44 <sharoonthomas> nicoe: cedk: did we make any progress on that ? | ||
| 2013-07-22 11:44 <cedk> sharoonthomas: not me | ||
| 2013-07-22 11:45 <nicoe> sharoonthomas: no, it was the subject of GSOC but the student failed | ||
| 2013-07-22 11:45 <sharoonthomas> nicoe: cedk: ok | ||
| 2013-07-22 11:46 <cedk> sharoonthomas: it is about fodt = flat odt | ||
| 2013-07-22 11:46 <sharoonthomas> cedk: got it https://code.google.com/p/tryton/wiki/gsoc2012ideas#Add_support_of_FODT_for_report | ||
| 2013-07-22 11:51 <cedk> sharoonthomas: I have some code if you want | ||
| 2013-07-22 11:52 <sharoonthomas> cedk: sure, please | ||
| 2013-07-22 11:56 <cedk> sharoonthomas: http://codereview.appspot.com/11591044 | ||
| 2013-07-22 13:18 <vishesh> cedk: Hey, I have a patch for MPTT performance improvement. http://codereview.tryton.org/993002/ | ||
| 2013-07-22 13:30 <cedk> vishesh: commented | ||
| 2013-07-22 13:31 <cedk> vishesh: I guess the speedup is because you dropped the order of the tree | ||
| 2013-07-22 13:31 <cedk> maybe it is something we don't need | ||
| 2013-07-22 13:32 <vishesh> cedk: What do we mean by order here? (I | ||
| 2013-07-22 13:33 <vishesh> (I'm new to tryton) I understand order is sorting. So when we search, the order should be respected | ||
| 2013-07-22 13:34 <cedk> vishesh: MPTT is about numbering the tree, so you need to follow an order for that | ||
| 2013-07-22 13:34 <cedk> vishesh: in current implementation, it uses the default order of the Model | ||
| 2013-07-22 13:35 <cedk> vishesh: in your implementation, the order is quiet random because it is last inserted is last one | ||
| 2013-07-22 13:37 <vishesh> Ah, got your point | ||
| 2013-07-22 13:38 <cedk> vishesh: it is commented in line 1920 | ||
| 2013-07-22 13:38 <cedk> vishesh: but maybe we don't need it | ||
| 2013-07-22 13:39 <vishesh> Yeah. | ||
| 2013-07-22 13:41 <vishesh> What's the benfit of maintaining the order? | ||
| 2013-07-22 13:41 <cedk> vishesh: for now, I only see one is to fetch the tree flatten by this order | ||
| 2013-07-22 13:43 <vishesh> If its not a common use case, there is little benefit supporting it. | ||
| 2013-07-22 13:44 <cedk> vishesh: yes | ||
| 2013-07-22 13:45 <vishesh> cedk: I will work on your comments and upload updated patch | ||
| 2013-07-22 13:46 <cedk> vishesh: ok but don't try to support order for now | ||
| 2013-07-22 13:47 <vishesh> cedk: Ok. | ||
| 2013-07-22 13:47 <cedk> vishesh: did you check if you could use your update code instead of rebuild_tree is more cases ? | ||
| 2013-07-22 13:47 <cedk> vishesh: for now, if there is more than 1 records to update, we rebuild the all tree | ||
| 2013-07-22 13:48 <cedk> vishesh: I guess our code could perhaps be used for longuer list | ||
| 2013-07-22 13:49 <vishesh> Yeah. I wrote _make_space() function for that purpose | ||
| 2013-07-22 13:49 <vishesh> But currently, we are rebuilding trees for more than 1 records | ||
| 2013-07-22 13:49 <vishesh> I didn't look into that yet | ||
| 2013-07-22 14:09 <vishesh> cedk: What's the docstring format used in tryton? You mentioned not to use the one I use in patch. I got that format somewhere in tryton code | ||
| 2013-07-22 14:26 <cedk> vishesh: none | ||
| 2013-07-22 14:26 <cedk> vishesh: it was used before but we discover there was no benefit | ||
| 2013-07-22 14:30 <vishesh> Ok. So should I remove all comments? | ||
| 2013-07-22 14:35 <cedk> vishesh: write only what is not obvious |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!