IRC logs of #tryton for Thursday, 2014-11-27

chat.freenode.net #tryton log beginning Thu Nov 27 00:00:01 CET 2014
2014-11-27 00:01 -!- hiaselhans(~Thunderbi@chello212186043057.408.14.vie.surfer.at) has joined #tryton
2014-11-27 00:36 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton
2014-11-27 00:45 -!- digitalsatori(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 00:49 -!- digitalsatori(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 00:56 -!- leio(~leio@gentoo/developer/leio) has joined #tryton
2014-11-27 00:59 -!- digitalsatori1(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 01:23 -!- digitalsatori(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 01:40 -!- udono(~udono@p50938317.dip0.t-ipconnect.de) has joined #tryton
2014-11-27 03:44 -!- TheCowboy(~TheCowboy@c-50-189-10-141.hsd1.ct.comcast.net) has joined #tryton
2014-11-27 05:05 -!- Alex_E1(~Alex_E@p578F3EC9.dip0.t-ipconnect.de) has joined #tryton
2014-11-27 05:35 -!- sunny_dealmeida(~quassel@210.89.41.115) has joined #tryton
2014-11-27 06:01 -!- yangoon1(~mathiasb@p549F3256.dip0.t-ipconnect.de) has joined #tryton
2014-11-27 06:25 -!- digitalsatori(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 06:36 -!- digitalsatori1(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 06:40 -!- frispete_(~frispete@p54A92E72.dip0.t-ipconnect.de) has joined #tryton
2014-11-27 07:17 -!- horli(~gregor@chello084113024052.5.12.vie.surfer.at) has joined #tryton
2014-11-27 07:17 -!- horli(~gregor@chello084113024052.5.12.vie.surfer.at) has left #tryton
2014-11-27 07:53 -!- pjstevns(~Thunderbi@2001:981:7170:1:fd99:353:2a48:60b2) has joined #tryton
2014-11-27 07:59 -!- prksh(~prksh@103.245.118.154) has joined #tryton
2014-11-27 08:03 -!- horli(~gregor@chello084113024052.5.12.vie.surfer.at) has joined #tryton
2014-11-27 08:03 -!- horli(~gregor@chello084113024052.5.12.vie.surfer.at) has left #tryton
2014-11-27 08:07 -!- vak0160(~kvirc@36.72.229.107) has joined #tryton
2014-11-27 08:08 -!- vak0160(~kvirc@36.72.229.107) has joined #tryton
2014-11-27 08:12 -!- vak0160(~kvirc@36.72.229.107) has left #tryton
2014-11-27 08:12 -!- pobsteta(~Thunderbi@4cb54-3-88-160-87-54.fbx.proxad.net) has joined #tryton
2014-11-27 08:16 -!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton
2014-11-27 08:55 -!- horli(~gregor@chello084113024052.5.12.vie.surfer.at) has joined #tryton
2014-11-27 09:09 -!- jeancavallo(~giovanni@bob75-9-88-181-2-176.fbx.proxad.net) has joined #tryton
2014-11-27 09:29 -!- corro(~corro@46.22.23.85) has joined #tryton
2014-11-27 09:29 -!- LordVan(~LordVan@gentoo/developer/LordVan) has joined #tryton
2014-11-27 09:30 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton
2014-11-27 09:33 -!- digitalsatori(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 09:35 -!- bechamel(~Adium@62-197-96-189.teledisnet.be) has joined #tryton
2014-11-27 09:42 -!- digitalsatori(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 09:49 -!- digitalsatori(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 10:17 -!- digitalsatori(~Thunderbi@116.234.112.203) has joined #tryton
2014-11-27 10:41 -!- horli(~gregor@78.142.163.132) has joined #tryton
2014-11-27 10:45 -!- horli(~gregor@78.142.163.132) has left #tryton
2014-11-27 10:53 <pobsteta> Hi all. I want to update a many2many attribute with an on_change_with function but this code http://pastebin.com/RBfMx8V7 don't update the attribute protection ?
2014-11-27 11:00 <cedk> pobsteta: you mean the value
2014-11-27 11:01 <cedk> pobsteta: you must return a list of ids
2014-11-27 11:01 <cedk> pobsteta: by the way, why usgin SQL query when you can just use the ORM
2014-11-27 11:06 <cedk> pobsteta: oh I see there is a special operator
2014-11-27 11:07 <pobsteta> cedk: a list like this : {1, 2} or [1 , 2] ?
2014-11-27 11:09 <cedk> pobsteta: list = []
2014-11-27 11:14 -!- frispete(~frispete@p54A92E72.dip0.t-ipconnect.de) has joined #tryton
2014-11-27 11:15 <pobsteta> how can i use the ORM ?
2014-11-27 11:17 <cedk> pobsteta: not with custom operator for now
2014-11-27 11:20 <pobsteta> ok it work, thanks for all !
2014-11-27 11:24 -!- mar(~marius@v100.nfq.lt) has joined #tryton
2014-11-27 11:25 <mar> i coudn't find guidelines for creating a patch so https://bugs.tryton.org/issue4372
2014-11-27 11:28 <cedk> mar: https://code.google.com/p/tryton/wiki/HowtoContribute
2014-11-27 11:29 <cedk> Pilou: the quick start is still way too long
2014-11-27 11:30 <mar> thanks
2014-11-27 11:33 -!- nicoe(~nicoe@117.103-247-81.adsl-dyn.isp.belgacom.be) has joined #tryton
2014-11-27 11:34 <mar> how do i get a password in codereview?
2014-11-27 11:34 <cedk> mar: it uses google account
2014-11-27 11:37 -!- udono(~udono@p50938317.dip0.t-ipconnect.de) has joined #tryton
2014-11-27 11:37 <Pilou> cedk: which steps are unnecessary ?
2014-11-27 11:37 <cedk> Pilou: i'm working on a patch
2014-11-27 11:37 <cedk> Pilou: I think I will remove a lot
2014-11-27 11:38 -!- VaticanCameos(~pritishc@103.245.118.154) has joined #tryton
2014-11-27 11:38 <mar> cedk, http://codereview.tryton.org/6691002
2014-11-27 11:39 <cedk> Pilou: I give up, there are way too much of blabla
2014-11-27 11:39 <cedk> Pilou: I understand now why people tells it is too complicate to contribute
2014-11-27 11:39 <cedk> to contribute it is 4 lines
2014-11-27 11:40 <mar> probably missed ":" :/
2014-11-27 11:43 <cedk> this howto tunrs the contribution process into a bureaucratic stuff
2014-11-27 11:44 <Pilou> My idea was to list all the steps which could permit a contributor to have his contribution approved.
2014-11-27 11:44 <mar> cedk, is it good enough?
2014-11-27 11:44 <mar> or do I still miss something?
2014-11-27 11:45 <cedk> Pilou: that's a dream
2014-11-27 11:45 <Pilou> could you elaborate ?
2014-11-27 11:45 -!- kstenger(~karla@200.124.209.158) has joined #tryton
2014-11-27 11:45 <cedk> Pilou: a contribution should be just submiting a patch
2014-11-27 11:45 <Pilou> but it's not
2014-11-27 11:46 <cedk> Pilou: when i conrtibute to cPython, I don't care at all about all the internal stuffs/rules
2014-11-27 11:46 <Pilou> I follow the python quick start (https://docs.python.org/devguide/) and added the codereview parts
2014-11-27 11:46 <cedk> Pilou: I just submit a patch
2014-11-27 11:46 <cedk> mar: what?
2014-11-27 11:47 <mar> https://bugs.tryton.org/issue4372
2014-11-27 11:47 <Timitos> cedk: there are so many points where you can fail. if somebody wants to do his first contribution it is not really only 4 line
2014-11-27 11:47 <mar> do I miss something in this contribution
2014-11-27 11:48 <cedk> Timitos: it should not
2014-11-27 11:48 <cedk> Timitos: improving workflow is not about adding documentation, it is about reducing the possible failure
2014-11-27 11:48 <cedk> mar: I don't think
2014-11-27 11:49 <Pilou> Timitos: indeed
2014-11-27 11:50 <Pilou> cedk: i only wrote documentation for the current workflow
2014-11-27 11:50 <Timitos> cedk: at least you need to create a google account if you dont have one before you can start with 4 lines and you have to create a account on the bug tracker
2014-11-27 11:50 <Pilou> cedk: improvements of the workflow should be discussed in the ML
2014-11-27 11:50 <cedk> If I have to read 200 lines of doc, to submit a patch than I will fail at reading
2014-11-27 11:50 <yangoon> Pilou: +1
2014-11-27 11:50 <cedk> Timitos: account to bug tracker is not required
2014-11-27 11:51 <mar> github is the way :)
2014-11-27 11:51 <cedk> Pilou: except people reading it, just give up because it is too complicate to read
2014-11-27 11:51 <cedk> mar: the workflow is easier than github, 4 lines
2014-11-27 11:52 <Pilou> (soon google account will not be required)
2014-11-27 11:52 <cedk> mar: and I count running vi and cd
2014-11-27 11:53 <mar> it took me 30 minutes to do those 4 commands
2014-11-27 11:53 <mar> i would have done it on github in 5 minutes :)
2014-11-27 11:54 <cedk> mar: I count 13min on irc
2014-11-27 11:55 <cedk> mar: any way, github is not the discussion, it is a privative platform and we are a freesoftware
2014-11-27 11:55 <Timitos> mar: donĀ“t forget, that you are already used to the contribution process on github. you need to think of your first time as you had to create a pull request on github
2014-11-27 11:57 <cedk> Pilou: FYI, now the process doesn't require anymore to attach the patch to the bug tracker
2014-11-27 11:58 <cedk> I will work on a bot, that will add the review id to issue for each new review that has issuexxx in its comment
2014-11-27 11:59 -!- horli(~gregor@78.142.163.132) has joined #tryton
2014-11-27 11:59 -!- horli(~gregor@78.142.163.132) has left #tryton
2014-11-27 12:00 <cedk> mar: also you should now count how much time for the next one?
2014-11-27 12:01 <rmu> I contributed I think about 2-3 patches, and I didn't find it too hard to do it, after finding out about hgreview.
2014-11-27 12:02 <rmu> things that were non-obvious to me: how to enter the bug tracker issue id into the hreview description, and that it was necessary to attach a patch to the bug after review was completed
2014-11-27 12:03 <cedk> rmu: I'm also working on it: https://bitbucket.org/nicoe/hgreview/issue/18/allow-to-edit-the-description
2014-11-27 12:04 <cedk> rmu: and for the patch attachment, it is gone as now we (committers) can download the patch with all information ready to be imported in hg
2014-11-27 12:04 <Pilou> cedk: how is handled the commit message ?
2014-11-27 12:04 -!- mariomop(~quassel@181.110.68.69) has joined #tryton
2014-11-27 12:05 <cedk> Pilou: the commit message is the review dsubject (with module name) and the review description
2014-11-27 12:05 <cedk> I also plan to add to hgreview a hook on commit to prefill the commit message with the review one
2014-11-27 12:06 <cedk> Pilou: alos the review id is automaticaly appended to the patch
2014-11-27 12:09 <cedk> Pilou: look at http://codereview.tryton.org/download/issue5811002_20001.diff
2014-11-27 12:37 -!- smarro(~sebastian@190.105.93.196) has joined #tryton
2014-11-27 13:05 -!- ytz(~ytz@secure2.options-it.com) has joined #tryton
2014-11-27 13:30 <cedk> nicoe: I could not test: http://codereview.tryton.org/14721002/
2014-11-27 13:30 <cedk> nicoe: I have not access to the user
2014-11-27 13:31 <cedk> nicoe: I also think it should a user on moretus with a @tryton.org email
2014-11-27 13:54 -!- frispete(~frispete@p54A92E72.dip0.t-ipconnect.de) has joined #tryton
2014-11-27 13:59 -!- vcardon(~vcardon@bureau-sdsl.tranquil.it) has joined #tryton
2014-11-27 14:03 -!- hiaselhans(~Thunderbi@chello212186043057.408.14.vie.surfer.at) has joined #tryton
2014-11-27 14:12 <nicoe> cedk: indeed we should promote this test to something more official
2014-11-27 14:27 -!- pablovannini(~pablo@host126.186-109-85.telecom.net.ar) has joined #tryton
2014-11-27 14:56 <mar> can this be a rounding error: http://hg.tryton.org/trytond/trytond/modules/stock/file/b9947becd5e5/move.py#l797
2014-11-27 14:57 <mar> i picked_quantities = 0.999999999 < move.quantity = 1
2014-11-27 14:59 <mar> and is it possible to have a race condition in assign_try method? I mean when two assignments happens concurrently?
2014-11-27 15:09 <pokoli> mar: stock_moves table is locked on assign_try
2014-11-27 15:09 <pokoli> mar: http://hg.tryton.org/trytond/trytond/modules/stock/file/b9947becd5e5/move.py#l746
2014-11-27 15:12 <mar> but it's locked in exclusive mode
2014-11-27 15:13 <mar> which means reads are still possible
2014-11-27 15:15 <mar> so it doesn't block loading quantities which may be wrong
2014-11-27 15:15 <mar> if another assign is happening at the same time?
2014-11-27 15:23 <mar> am I right? :)
2014-11-27 15:38 <pokoli> mar: i imagine that yes, you're right, but haven't tested it
2014-11-27 15:44 -!- hiaselhans(~Thunderbi@chello212186043057.408.14.vie.surfer.at) has joined #tryton
2014-11-27 15:47 <mar> I have a situation where there are more products assigned than available
2014-11-27 15:51 <pokoli> mar: what i can tell is that i can not see any reason to block all the stock table in ACCESS EXCLUSIVE mode
2014-11-27 15:52 <mar> probably quantity loading should be done with "FOR UPDATE"
2014-11-27 15:55 <pokoli> mar: could you explain how you get to the situation where tehere are more products assigned than available?
2014-11-27 15:55 <mar> open two tryton windows, create two productions which uses same products
2014-11-27 15:56 <mar> both productions should have "many" moves
2014-11-27 15:56 <mar> so that assignment doesn't happen imediately
2014-11-27 15:56 <mar> and click assign button in both windows
2014-11-27 15:56 <mar> result = both production are fully assigned
2014-11-27 15:57 <mar> expected result: one production is not assigned (missing qty)
2014-11-27 15:57 <mar> if running one by one I get expected result, running them concurrently I get both of them assigned ;)
2014-11-27 16:00 <mar> for best results "offending" move should probably be last
2014-11-27 16:01 <pokoli> mar: understood
2014-11-27 16:02 <pokoli> mar: main problem about "FOR UPDATE" is that python-sql doesn't support it
2014-11-27 16:02 <mar> I believe it does
2014-11-27 16:03 <mar> https://code.google.com/p/python-sql/source/browse/sql/__init__.py#282
2014-11-27 16:03 <mar> https://code.google.com/p/python-sql/source/browse/sql/__init__.py#364
2014-11-27 16:04 <mar> at least the current version
2014-11-27 16:04 <pokoli> mar: ouch, i missed this line :)
2014-11-27 16:05 <pokoli> mar: yes, you're right it supports it
2014-11-27 16:06 <pokoli> mar: so go ahead and write a patch
2014-11-27 16:07 <mar> I'm not sure about the correct way
2014-11-27 16:07 <pokoli> mar: can help you on this (at least try)
2014-11-27 16:09 <mar> http://hg.tryton.org/trytond/trytond/modules/stock/file/b9947becd5e5/move.py#l1079
2014-11-27 16:09 <mar> adding .for_ here?
2014-11-27 16:09 <pokoli> mar: first of all, i think you need some kind of flag to especify if it's for update or not
2014-11-27 16:10 <pokoli> mar: forget it, not sure about it :)
2014-11-27 16:10 <pokoli> mar: i think that you don't need to look on the union all, but only on the first two queries that are from move table
2014-11-27 16:14 <rmu> mar: I would start writing a test-case/test-scenario that reproduces the error
2014-11-27 16:18 <pokoli> rmu: not sure if possible because it's all about concurrency
2014-11-27 16:18 <pokoli> mar: at least you can open an issue on the bug tracker :)
2014-11-27 16:23 <rmu> mar: what database are you using?
2014-11-27 16:30 <mar> postgres
2014-11-27 16:33 -!- pobsteta(~Thunderbi@4cb54-3-88-160-87-54.fbx.proxad.net) has joined #tryton
2014-11-27 16:39 -!- prksh(~prksh@101.0.57.37) has joined #tryton
2014-11-27 16:40 -!- horli(~gregor@78.142.163.132) has joined #tryton
2014-11-27 16:40 -!- horli(~gregor@78.142.163.132) has left #tryton
2014-11-27 16:42 <mar> https://bugs.tryton.org/issue4373
2014-11-27 16:44 <pokoli> mar: will you try to provide a patch?
2014-11-27 16:45 <mar> https://bugs.tryton.org/issue2280
2014-11-27 16:46 <mar> this is related
2014-11-27 16:46 <mar> pokoli, not until monday ;)
2014-11-27 16:47 <cedk> mar: I can not see how this can happen, assignation needs to update the table
2014-11-27 16:47 <cedk> mar: so lock IN EXCLUSIVE MODE should prevent that
2014-11-27 16:50 <pokoli> cedk: I imagine that the first read is done without the assigned data, so the other transaction sees the starting values, and then it locks when trying to write the moves
2014-11-27 16:50 <mar> reading quantities isn't blocking operation. 1. process1 locks in exclusive mode, 2. process2 locks in exclusive mode, 3. process1 reads quantities, 4. process2 reads quantities, 5. process1 assigns, releases lock, 6. process2 assigns, releases lock
2014-11-27 16:52 <cedk> mar: how 5 if 2 was done
2014-11-27 16:54 <cedk> and lock table in exclusive mode are mutualy exclusif
2014-11-27 16:56 <cedk> I think the culpitre is the change to repeatable read instead of serializable
2014-11-27 16:59 -!- TheCowboy(~TheCowboy@c-50-189-10-141.hsd1.ct.comcast.net) has joined #tryton
2014-11-27 17:02 <rmu> this http://hg.tryton.org/trytond/trytond/modules/purchase/file/330c799c162d/purchase.py#l1264 causes div by zero, interestingly, sale does it differently: http://hg.tryton.org/trytond/trytond/modules/sale/file/cc72bf5c0455/sale.py#l1341
2014-11-27 17:02 <rmu> https://bugs.tryton.org/issue4374
2014-11-27 17:07 <mar> i'll try to log all queries happening in order for the concurrency issue
2014-11-27 17:19 <cedk> mar: for me, it is clear what happens
2014-11-27 17:19 <cedk> mar: taking your numbers:
2014-11-27 17:20 <cedk> 1, 3, 5, 2, 4, 6
2014-11-27 17:20 <cedk> but 4 and 6 are reading the values before the commit of 5
2014-11-27 17:20 <cedk> because it uses the repeatable read
2014-11-27 17:42 -!- vcardon(~vcardon@bureau-sdsl.tranquil.it) has left #tryton
2014-11-27 17:45 <rmu> http://martin.kleppmann.com/2014/11/25/hermitage-testing-the-i-in-acid.html, https://github.com/ept/hermitage
2014-11-27 17:45 -!- prksh(~prksh@101.0.57.38) has joined #tryton
2014-11-27 18:00 -!- prksh(~prksh@180.188.247.36) has joined #tryton
2014-11-27 18:12 -!- Telesight(~anthony@77-175-158-148.FTTH.ispfabriek.nl) has joined #tryton
2014-11-27 18:38 <cedk> nicoe: I migrated reviewbot to his own user and created an account reviewbot@tryton.org
2014-11-27 18:43 <cedk> nicoe: but I see it uses hgreview and so it request the password in stdin
2014-11-27 18:44 <cedk> nicoe: of course the session is stored but for 30 days
2014-11-27 18:44 <cedk> nicoe: how did you manage it?
2014-11-27 18:45 -!- sunny_dealmeida(~quassel@203.76.183.203) has joined #tryton
2014-11-27 19:09 <cedk> nicoe: OK I found, it is fixed with dev version of hgreview
2014-11-27 20:02 -!- prksh_(~prksh@101.0.57.38) has joined #tryton
2014-11-27 20:12 -!- prksh(~prksh@180.188.247.243) has joined #tryton
2014-11-27 22:53 -!- hiaselhans(~Thunderbi@chello212186043057.408.14.vie.surfer.at) has joined #tryton
2014-11-27 23:01 -!- horli(~gregor@chello084113024052.5.12.vie.surfer.at) has joined #tryton
2014-11-27 23:36 -!- ytz(~ytz@opfw01.options-it.com) has joined #tryton
2014-11-27 23:53 -!- hiaselhans1(~Thunderbi@chello212186043057.408.14.vie.surfer.at) has joined #tryton

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!