IRC logs of #tryton for Friday, 2016-11-11

chat.freenode.net #tryton log beginning Fri Nov 11 00:00:01 CET 2016
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton00:35
-!- nramirezuy(~nramirezu@r167-62-186-30.dialup.adsl.anteldata.net.uy) has joined #tryton01:17
-!- nramirezuy(~nramirezu@r167-62-204-135.dialup.adsl.anteldata.net.uy) has joined #tryton01:54
-!- apostatize(~visavis@unaffiliated/apostatize) has joined #tryton02:06
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton02:31
-!- smarro(~sebastian@181.16.7.104) has joined #tryton03:16
-!- perilla(~perilla@191.100.15.78) has joined #tryton03:18
-!- kstenger1(~karla@r186-54-186-51.dialup.adsl.anteldata.net.uy) has joined #tryton04:32
-!- dj_xatra(~dj_xatra@217.166.83.130) has joined #tryton07:47
-!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton08:41
-!- udono(~udono@tmo-112-227.customers.d1-online.com) has joined #tryton09:33
-!- rpit(~rpit@aftr-37-24-151-103.unity-media.net) has joined #tryton09:35
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton10:05
pokolishould tax_identifier set on _check_modify_excluded field?10:37
pokoliLet me explaing what I found: I have a paid invoice created after the tax_identifier field was added, so if I unreconcile it's lines I get and error that I can not modify it's lines because the post, calls the set_number, which's sets the tax identifier for the invoice and then raises the error10:38
pokoliThe other solution is to fill the tax_identifier on migration for posted invoices10:39
pokolieverything goes well on new created invoices as the tax_identifier is set on posting10:42
pokoliIndeed, the error is raised if the company has no tax_identifier set, as it tries to write the None value to the paid invoice when setting number10:58
-!- csotelo(~csotelo@190.238.132.117) has joined #tryton11:06
-!- thaneor(~ldlc6@179.26.17.183) has joined #tryton11:07
cedkpokoli: indeed we should separate tax identifier from set_number11:28
cedkpokoli: or better to not set a tax identifier if the state is already posted11:32
cedkpokoli: but as number is neither in _check_modify_excluded, number should also be skiped11:33
-!- smarro(~sebastian@181.16.7.104) has joined #tryton11:35
pokolicedk: I think it's better to not modify number nor tax_identifier if invoice is not in draft state, what do you think?11:38
cedkpokoli: no because it is also about validated11:38
cedkpokoli: so only the posted, paid state should be skipped11:39
cedkpokoli: just like check_modify does11:39
pokolicedk: ok, I'm creating and issue + codereview11:40
-!- mariomop(~quassel@181.110.216.131) has joined #tryton12:13
-!- rajeevn(~rajeevn@unaffiliated/rajeevn) has joined #tryton12:44
-!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton13:41
-!- lukio(~lukio@191.85.185.103) has joined #tryton14:10
-!- smarro(~sebastian@181.16.7.104) has joined #tryton14:12
-!- udono(~udono@ip-178-202-243-21.hsi09.unitymediagroup.de) has joined #tryton14:14
-!- perilla(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton14:27
-!- perilla1(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton14:35
-!- lukio(~lukio@191.85.185.103) has left #tryton14:42
-!- andrespoliti(~andrespol@250-183-89-200.fibertel.com.ar) has joined #tryton15:28
andrespolitihi, we are making an extension to party that changes the type of a one2many field to a many2many by redefining it, but it doesn't work. If we change the type of the field in the original party module, it works. Is this a bug or do we have to do it another way?15:28
-!- kstenger(~karla@r186-54-186-51.dialup.adsl.anteldata.net.uy) has joined #tryton15:28
cedkandrespoliti: it is not supported to change the type of a field15:29
cedkandrespoliti: also it will break any other modules that use this field15:31
pokoliandrespoliti: why you don't add a new field? and change the views?15:36
andrespolitibecause it's the addresses field, which is used by other modules15:37
pokoliandrespoliti: wow. Could you explain the rational of this change?15:38
pokoliandrespoliti: AFAIU if you need the same address for diferent parties, you should duplicate it. So if the party moves to another place, only the address of one party is updated15:39
andrespolitiyes, it's true, but we have to adapt to an external system that is modeled that way15:43
cedkandrespoliti: make the adaption outside the system15:44
-!- pollex(~pollex@250-183-89-200.fibertel.com.ar) has joined #tryton15:45
-!- andrespoliti(~andrespol@250-183-89-200.fibertel.com.ar) has joined #tryton15:46
-!- kstenger1(~karla@r186-55-77-202.dialup.adsl.anteldata.net.uy) has joined #tryton16:33
-!- nramirezuy(~nramirezu@r167-62-6-202.dialup.adsl.anteldata.net.uy) has joined #tryton16:52
-!- afibanez(~afibanez@170.red-80-28-119.adsl.static.ccgg.telefonica.net) has joined #tryton17:04
-!- rpit(~rpit@2a02:908:e672:1520:56ee:75ff:fe0d:d3c7) has joined #tryton17:19
-!- JosDzG(~Thunderbi@fixed-188-72-187-188-72-36.iusacell.net) has joined #tryton17:20
-!- rpit(~rpit@2a02:908:e672:1520:56ee:75ff:fe0d:d3c7) has joined #tryton17:29
-!- lukio(~lukio@181.45.71.170) has joined #tryton18:10
-!- perilla(~perilla@corp-190-57-169-210.cue.puntonet.ec) has left #tryton18:21
-!- perilla(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton18:21
-!- csotelo(~csotelo@2001:1388:49c5:308c:5644:1d95:dec5:ca75) has joined #tryton20:53
-!- thaneor(~ldlc6@r179-25-53-47.dialup.adsl.anteldata.net.uy) has joined #tryton21:32
-!- perilla1(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton21:39
-!- perilla(~perilla@corp-190-57-169-210.cue.puntonet.ec) has left #tryton21:43
-!- perilla1(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton22:04
-!- perilla1(~perilla@corp-190-57-169-210.cue.puntonet.ec) has left #tryton22:09
-!- thaneor(~ldlc6@r179-25-53-47.dialup.adsl.anteldata.net.uy) has joined #tryton23:01
-!- udono(~udono@ip-178-202-243-21.hsi09.unitymediagroup.de) has joined #tryton23:04

Generated by irclog2html.py 2.11.0 by Marius Gedminas - find it at mg.pov.lt!