IRC logs of #tryton for Wednesday, 2017-03-29

chat.freenode.net #tryton log beginning Wed Mar 29 00:00:01 CEST 2017
-!- thaneor(~ldlc6@r167-56-51-129.dialup.adsl.anteldata.net.uy) has joined #tryton00:20
-!- smarro(~sebastian@cust-138-45-13-200.trynet.com.ar) has joined #tryton00:25
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton00:27
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton01:39
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton01:49
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton02:52
-!- smarro(~sebastian@cust-138-45-13-200.trynet.com.ar) has joined #tryton03:35
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton04:00
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton04:28
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton04:39
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton06:03
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton06:14
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton06:58
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton07:51
-!- dj_xatra(~dj_xatra@217.166.83.130) has joined #tryton08:02
-!- morfeokmg(~morfeokmg@201.103.192.201) has joined #tryton08:05
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton08:34
-!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton08:42
-!- rpit(~rpit@2a02:908:e672:7480:56ee:75ff:fe0d:d3c7) has joined #tryton08:45
-!- rpit(~rpit@2a02:908:e672:7480:56ee:75ff:fe0d:d3c7) has joined #tryton08:49
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton08:51
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton09:11
-!- mrichez(~smuxi@mail.saluc.com) has joined #tryton09:17
pokolicedk: I'm reading your messages now09:28
pokolicedk: I don't mather about the time (we have this patch already applied on test environments) but I don't see what else must be done in the patch09:32
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton09:46
cedkpokoli: that's the problem, it is not about "what est must be done"09:48
cedkpokoli: it is about finding the right solution09:49
cedkpokoli: and so what is exhausting is to have to tell many times, it is not the right solution09:49
cedkI have already reduced my review job for others because when after 10 reviews there are still the same issue, it is a waste of time09:51
-!- rpit(~rpit@2a02:908:e672:7480:56ee:75ff:fe0d:d3c7) has joined #tryton09:51
pokolicedk: sometimes review comments are complex to understand09:54
pokolicedk: and then you don't realese what's the rigth (or best) solution until the third comment09:55
pokolicedk: indeed, it's a litlle bit exhausiting for the other side also09:55
pokolicedk: but at I think that after the time spent we reach the goal (to have the right solution)09:56
cedkpokoli: I think I do not care to hear about that.09:57
cedkpokoli: then I will stop even sooner reviewing, especially patch that I do not really care09:57
pokolicedk: you are free to do whatever you want with your time09:59
pokolicedk: but what I want to note is that we all have to put from our side10:00
cedkAs I have the feeling that people relies on my reviews to get things done properly, I will just stop reviewing after the 5th set10:06
pokolicedk: so you mean that you will "discard" patches after the 5th set?10:09
cedkjust ignore10:11
pokolithen review will be there forever without feedback and never commited10:11
cedkyep10:12
pokoliand will produce the feeling of: "Nobody cares about my patches"10:12
cedkI think it is the only solution for me to stay sane and push pressure to contributor to think twice before submitting a patch10:13
pokolicedk: yeah, it's important for you to stay sane :)10:14
pokolicedk: ok, but maybe it's worth to send an email to dev ML explaining the situation10:14
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton10:21
-!- nicoe(~nicoe@host-85-201-184-151.dynamic.voo.be) has joined #tryton10:30
mrichezcedk: hi Ced, following your discuss on reviews : so what's the best way, for beginners to have advices on their way of coding in tryton? Trying to post a patch is a way of learning, no ? In the end, we could be afraid to post a patch because we are not expert but good will...10:38
cedkmrichez: I do not know, I have no solution10:40
cedkbut an initial problem is there is not enough people reviewing10:40
mrichezcedk: maybe but we need some tryton level in coding10:42
pokolimrichez: for sure it's not good to stop doing things because you are afraid, so I will say ask whatever doubts you have and we will try to answer them10:42
pokolicedk: agree with mrichez it's not easy to review until you have some background. Indeed, I've been reviewing for a lot of time and I'm still learing things everyday10:43
pokolicedk: don't now if it will help if I (or somebody else) give a first review on patches and after all the patches are review, you give the final review10:53
tbruyere_I'm not often on IRC but I find the discussion important: my dream would be to become "reviewer" ... But currently I just have time to read and monitor the "patch" and "issue". My level in python and tryton is not yet enough to allow me remarks in other codes. Unfortunately it is only excuses for not investing in the project really. I think this is the problem of many ....10:56
cedkpokoli: of course it will help, if there were a initial review11:03
cedkpokoli: but as far as we do not have enough reviewers, I do not see how it could work11:03
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton11:04
pokolicedk: correctme if I'm wrong, but currently you and me are the ones we are normally reviewing11:05
pokolicedk: so if we can provide some workflow to improve stay saner better. And if then more people join I'm sure we can find the space on the workflow11:06
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton11:10
-!- nicoe(~nicoe@85.201.184.151) has joined #tryton11:12
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton11:39
-!- csotelo(~csotelo@2001:1388:49c4:26:3b38:fb54:94df:ddbc) has joined #tryton11:49
-!- thaneor(~ldlc6@r179-25-33-251.dialup.adsl.anteldata.net.uy) has joined #tryton12:22
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton12:42
-!- smarro(~sebastian@cust-138-45-13-200.trynet.com.ar) has joined #tryton13:03
-!- mariomop(~quassel@186.125.16.84) has joined #tryton13:04
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton13:47
-!- smarro(~sebastian@cust-219-46-13-200.trynet.com.ar) has joined #tryton14:13
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton14:24
pokolicedk: about the dict patch, I imagine you propse to add a json adapter using pyscopg2 extras but I have some doubts:14:34
pokolijsonb is only supported since 2.5.4 (but we required 2.5), should I update the require version or add conditional support?14:35
cedkpokoli: precesly what I do not want to do, thinking about that now15:11
pokolicedk: ok, sorry and take your time15:16
cedkpokoli: I will talk about that in 1 month15:18
pokolicedk: are you going to have holidays untill the release?15:19
cedkno15:25
pokolicedk: I updated the review but please don't look at it until we talk about it :)15:28
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton15:31
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton16:12
-!- pijuli(~marc@170.red-80-28-119.adsl.static.ccgg.telefonica.net) has joined #tryton17:20
-!- pijuli(~marc@170.red-80-28-119.adsl.static.ccgg.telefonica.net) has left #tryton17:20
-!- marcP(~marc@170.red-80-28-119.adsl.static.ccgg.telefonica.net) has joined #tryton17:21
marcPHi everyone, every day question before going home is here :P This time is about changing a field marked as 'required=True' of product from a __setup__. I know how to change states and so, but not required flag. Any clue or example? I've been searching for it for a while17:23
pokolimarcP: indeed why try to don't add to much required fields to avoid this issues17:37
pokolimarcP: which field are we talking about?17:37
marcPpokoli: list_price, cost_price, cost_price_method and default_uom from product.template. By default are required but I won't need them ^^17:40
pokolimarcP: and you can not hide and enter a default value for it?17:41
marcPpokoli: yes, I can do that, it's an option :) just by curiosity, isn't it easier to change the requirement?17:43
pokolimarcP: have you tested setting required=False to the field and dropping the not null contraint?17:43
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton17:44
marcPdo you mean this? : cls.cost_price.required=False . If you do yes, I've tried. But didn't change the constrain. Anyway the form is still requiring me the field17:45
pokolimarcP: how have you done it?17:49
pokolimarcP: if you don't change the not null constraint the field will be required on the database17:49
-!- smarro(~sebastian@cust-138-45-13-200.trynet.com.ar) has joined #tryton17:54
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton18:08
-!- cryptic(~cryptic@67-8-35-31.res.bhn.net) has joined #tryton18:10
-!- smarro(~sebastian@200.13.45.138) has joined #tryton18:16
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton18:19
-!- smarro(~sebastian@cust-138-45-13-200.trynet.com.ar) has joined #tryton18:50
-!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton18:52
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton19:01
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton19:32
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton20:16
-!- smarro(~sebastian@200.13.46.123) has joined #tryton20:29
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton20:31
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton20:57
-!- lukio(~lukio@181.47.220.45) has joined #tryton21:11
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton21:28
-!- JosDzG(~Thunderbi@189.250.83.57) has joined #tryton21:33
-!- rpit(~rpit@aftr-37-24-149-139.unity-media.net) has joined #tryton21:35
-!- nicoe(~nicoe@2a02:a03f:30b2:3c00:ee55:f9ff:fe7b:f7ac) has joined #tryton21:44
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton21:56
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton22:24
-!- JosDzG(~Thunderbi@187.171.237.107) has joined #tryton22:26
-!- lukio(~lukio@181.47.220.45) has left #tryton22:40
-!- trilliji(~trilliji@cpe-67-255-39-42.stny.res.rr.com) has joined #tryton23:00

Generated by irclog2html.py 2.11.0 by Marius Gedminas - find it at mg.pov.lt!