IRC logs of #tryton for Wednesday, 2022-12-14

irc.libera.chat #tryton log beginning Wed Dec 14 12:00:01 AM CET 2022
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton23:13
-!- ChanServ changed mode/#tryton -> +o cedk 23:13
-!- OscarQ(~OscarQ@91.126.38.246) has joined #tryton06:30
-!- tbruyere(~Thunderbi@mail.saluc.com) has joined #tryton07:16
-!- mrichez(~Maxime@mail.saluc.com) has joined #tryton07:25
-!- rpit(~rpit@p200300c88f35d0008b509f4d786e7481.dip0.t-ipconnect.de) has joined #tryton08:05
-!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton08:15
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton08:24
-!- ChanServ changed mode/#tryton -> +o cedk 08:24
-!- htgoebel(~hartmut@p200300d5df17e70021a42b9464239412.dip0.t-ipconnect.de) has joined #tryton08:45
htgoebelGood mrning.08:45
htgoebelGreat to hear heptapod migration is coming next weekend :-)08:45
htgoebelThis will ease contributing for me a looooot.08:46
htgoebelThaks to everybody working on this08:46
pokolihtgoebel: normally the most complex work is coding and not using the review tools.08:51
-!- nicoe(~nicoe@2a02:578:852a:c00:18c2:1aff:fef9:2b7f) has joined #tryton08:52
htgoebelpokoli: I know. Anyhow requireing a google account for rietveld as well as the custom tooling is hindering me09:00
pokolihtgoebel: but you can start coding now and then convert your patches to the mercurial format. 09:07
htgoebelpokoli: :-)09:11
pokolicedk: is there any convention for using for named branches of merge requests? It will be a good idea to use issueXXXX with the issue number? 09:53
cedkpokoli: no and I do not think so10:05
cedkpokoli: if it is linked to an issue the commit message should have: Closes: #123410:06
cedkhttps://docs.gitlab.com/ee/user/project/issues/managing_issues.html#default-closing-pattern10:06
cedkI expect people to use meaningful names10:07
cedkalso many MR will no more be linked to an issue10:08
cedksee the website update10:10
pokolicedk: ok, so we expect to fill directly Merge Requests and link them directly with the discuss? 10:13
cedkand also topics name are ephemeral10:13
cedkpokoli: it is a possibility but I would put the discuss link in the MR comment, not the commit message10:14
pokolithat make sense10:15
cedkalso for me committers will have to "clean" MR commits to follow our guidelines10:23
pokoliI guess we prefer to rebase all MR commits into a single one as we do now? 10:26
cedkpokoli: I put it on the website10:30
cedkindeed I set for linear history but this does not mean to squash commits10:31
cedkindeed with evolve there is no reason to have MR with fix commits, commits should be amend10:31
cedkbut sometimes you may want a MR with multiple step commits because it is easier to review and to follow10:31
pokolicedk: Yes, I know there are multiple possiblities now, but the default behaviour should be just to amend right? 10:35
pokoliotherwise we may ask on the review to include specific chanege as separate commit 10:36
pokoliI agree that the best is to put it on website. I reviewed hegtapod and our guideliness to ensure everything is clear10:36
cedkpokoli: yes amend should be the default10:46
-!- mrichez(~Maxime@2a02:a03f:c2e8:f900:db7c:11fb:1fc6:3112) has joined #tryton11:46
-!- nicoe(~nicoe@2a02:578:852a:c00:18c2:1aff:fef9:2b7f) has joined #tryton11:52
-!- acaubet1(~Thunderbi@194.224.31.235) has joined #tryton12:00
-!- acaubet(~Thunderbi@75.red-95-127-34.staticip.rima-tde.net) has joined #tryton12:02
-!- acaubet1(~Thunderbi@194.224.31.235) has joined #tryton12:39
-!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton14:46
-!- nicoe(~nicoe@2a02:578:852a:c00:18c2:1aff:fef9:2b7f) has joined #tryton21:02

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!