IRC logs of #tryton for Wednesday, 2022-12-28

irc.libera.chat #tryton log beginning Wed Dec 28 12:00:01 AM CET 2022
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton23:42
-!- ChanServ changed mode/#tryton -> +o cedk 23:42
-!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton08:10
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton09:07
-!- ChanServ changed mode/#tryton -> +o cedk 09:07
-!- acaubet1(~Thunderbi@37.red-88-28-25.dynamicip.rima-tde.net) has joined #tryton09:58
-!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton10:09
pokolicedk: I think i messed up with this commit https://foss.heptapod.net/tryton/tryton/-/commit/bea854287e0041c8debd75b2c942b0ddb8d2a16f12:05
-!- acaubet1(~Thunderbi@194.224.31.235) has joined #tryton12:13
cedkpokoli: too late12:13
cedkpokoli: remove it12:13
cedkpokoli: why did not you put the configuration I sent you12:14
pokolicedk: tested to strip it but it does not work. only ooption is to rollback? 12:14
cedkpokoli: it is definitly in the repository now12:14
pokolicedk: I put it, indeed this was on another clone with the same config but it seems it does not worked12:14
cedkpokoli: you do not need other clones12:15
pokolicedk: ok, so I backed out the changeset and I will create the MR now12:19
cedkpokoli: fix your configuration first12:21
cedkpokoli: how did you merged as failed pipeline https://foss.heptapod.net/tryton/tryton/-/merge_requests/3812:24
pokolicedk: do not now. I think I inclued that commit in my topic and then it when public like the other12:25
cedkpokoli: if you are not going to be more careful, I will have to remove your owner rights12:27
pokolicedk: of course, nothing that I've done on prupose. I think it won't happer anymore if I avoid other clones12:27
pokolicedk: I do not undersand why isort failed. It seems it was run without any file 12:32
pokoliI just run isort on all files and all complaints are for other files, not for the stock_lot module. I will upload a MR with all the fixes12:34
cedkpokoli: because check are run only on MR so the commit was attached to a MR but you pushed it directly, so the script is failing because it is based on stack12:42
cedkpokoli: no we fix isort when files are changed, this policy did not change12:43
pokolicedk: but test are run twice? One on the MR and other on the commit? 12:44
pokoliok, then just close the MR of the isort fix12:44
cedkpokoli: check are only run on MR12:48
pokoliYes I understood that but I see that we run test twice which I'm not sure if its really worth 12:52
cedkpokoli: it is like that12:53
cedkpokoli: some poeple push directy :-/12:53
pokolicedk: Today its april fools day in Spain ;-) 12:54
-!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton15:00
-!- LordVan(~lordvan@gentoo/developer/lordvan) has joined #tryton18:11
LordVanhi18:11
LordVanI was wondering .. recently Gentoo removed dev-python/gevent .. but trytond uses it .. any chance that will be added to the overlay?18:13
-!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton18:22
LordVanah .. cedk is not here anymore .. I shall ask him tomorrow18:26

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!