| irc.libera.chat #tryton log beginning Fri Jan 13 12:10:01 AM CET 2023 | ||
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 00:34 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 00:34 | |
| -!- springwurm(~springwur@5.104.149.54) has joined #tryton | 06:07 | |
| -!- mrichez(~Maxime@mail.saluc.com) has joined #tryton | 07:30 | |
| -!- rpit(~rpit@2001:470:747a:2a:d888:168c:72e2:a8f5) has joined #tryton | 07:32 | |
| -!- rpit(~rpit@nat-guest.intevation.de) has joined #tryton | 07:50 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 08:35 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 08:35 | |
| -!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton | 08:39 | |
| -!- nicoe(~nicoe@2a02:578:852a:c00:18c2:1aff:fef9:2b7f) has joined #tryton | 09:02 | |
| -!- htgoebel(~hartmut@p200300d5df13f600257cef7c7ccac5f9.dip0.t-ipconnect.de) has joined #tryton | 09:15 | |
| htgoebel | Good morning | 09:37 |
|---|---|---|
| htgoebel | I prepared the association module for inclusion into the mono repo. | 09:37 |
| htgoebel | Now this was (and still is) a git repo. How can I easily integrate this into the mono repo while keeping the commit history for now as a reference until the review is done. | 09:37 |
| htgoebel | Of course, if the review/change history is not to be kept, I'd simply create a single commit | 09:37 |
| cedk | I think you better keep it outside | 09:51 |
| cedk | for now I do not think I will find time to review it | 09:52 |
| htgoebel | ced: I don't understand. | 09:54 |
| htgoebel | Maybe you could upload the current state of the development as a draft (drafts are not mergeable). | 09:54 |
| htgoebel | That way it won’t be lost and other can also help on your topic. | 09:54 |
| htgoebel | Quote from https://discuss.tryton.org/t/association-blueprint/1282/116?u=htgoebel | 09:55 |
| htgoebel | This is what I want to do | 09:55 |
| htgoebel | So I need to know technical details | 09:56 |
| cedk | htgoebel: I do not see the point of a draft, except spend everyone bandwith | 09:57 |
| cedk | and it is already "saved" in a repository somewhere | 10:02 |
| -!- nicoe(~nicoe@2a02:2788:54:1ff:18c2:1aff:fef9:2b7f) has joined #tryton | 11:14 | |
| -!- springwurm(~springwur@5.104.149.54) has joined #tryton | 13:02 | |
| htgoebel | cedk: | 13:21 |
| htgoebel | cedk: This is not a draft since it has been in review already, It' a submission | 13:22 |
| pokoli | htgoebel: which is the state of the work? Is the module working? Is the tryton tests passing? Is something missing to be implemented? | 13:50 |
| pokoli | htgoebel: if there is somethign missing, do you plan to work on it? | 13:51 |
| -!- nicoe(~nicoe@2a02:2788:54:1ff:18c2:1aff:fef9:2b7f) has joined #tryton | 14:17 | |
| cedk | I must say that I stopped to follow the discussion because too much was features were discussed at the same time | 14:22 |
| cedk | for me this usually result in too much bloat for a standard module | 14:22 |
| htgoebel | pokoli: FMPOV this module (as of my gitlab mirror) is ready for a serious review for inclusion. Concepts are documented, features are implemented, tests are passing AFAIKS, coverage is okay. And my plan is to work on this to get it finished at last. | 15:35 |
| htgoebel | cedk: Understood, discussion was long (both in duration and content). | 15:35 |
| htgoebel | cedk: I'll read the discussion again this weekend and may come with a proposal next week. | 15:35 |
| cedk | htgoebel: and I will not read before many months I guess | 15:39 |
| htgoebel | cedk: Anybody you can delegate this task to? | 15:42 |
| cedk | htgoebel: you see many people reviewing and maintaining code? | 15:45 |
| htgoebel | cedk: | 16:09 |
| htgoebel | ACTION apologizes for all the typos, I have a new keyboard, which I still need to learn | 16:11 |
| htgoebel | cedk: Well, my idea is to agree on a smaller feature set, which would be easier to review. Is this the way to go? | 16:14 |
| cedk | htgoebel: of course | 16:18 |
| htgoebel | cedk Fine, thanks, Have a nice weekend | 16:19 |
| -!- htgoebel(~hartmut@p200300d5df13f600257cef7c7ccac5f9.dip0.t-ipconnect.de) has left #tryton | 17:02 | |
| -!- yangoon(~yangoon@p5dd08deb.dip0.t-ipconnect.de) has joined #tryton | 20:43 | |
| -!- yangoon(~yangoon@p5dd08deb.dip0.t-ipconnect.de) has joined #tryton | 21:26 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!