| irc.libera.chat #tryton log beginning Fri Sep 29 12:10:01 AM CEST 2023 | ||
| -!- yangoon(~yangoon@pd9e4ad78.dip0.t-ipconnect.de) has joined #tryton | 02:26 | |
| -!- springwurm(~springwur@2a01:76c0:100:f500:d3bb:a2e0:d8cb:99f9) has joined #tryton | 05:13 | |
| -!- tbruyere(~Thunderbi@mail.saluc.com) has joined #tryton | 06:05 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 06:25 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 06:25 | |
| -!- mrichez(~Maxime@mail.saluc.com) has joined #tryton | 06:25 | |
| -!- rpit(~rpit@p200300c88f19a400b629dc14e46bf803.dip0.t-ipconnect.de) has joined #tryton | 06:30 | |
| -!- htgoebel(~htgoebel@p200300d5df0fd50053da8105f7a4d2de.dip0.t-ipconnect.de) has joined #tryton | 06:33 | |
| pokoli | htgoebel: I guess the mono-repo will be cloned on each run | 06:47 |
|---|---|---|
| pokoli | Normally third-party developers workon on released series, so they can just use pypi packages | 06:48 |
| pokoli | at least, this is what we do | 06:48 |
| htgoebel | pokoli: Will, we are preparing transition to 7.0, thus working on 6.9. | 06:57 |
| htgoebel | If wheels of current development head/tip would be available. this would ease this work a lot. | 06:58 |
| -!- udono(~udo@013-154-117-131.ip-addr.inexio.net) has joined #tryton | 06:59 | |
| pokoli | htgoebel: It should be possible to store packaeges on heptapod package registry: https://docs.gitlab.com/ee/user/packages/pypi_repository/ | 07:01 |
| -!- LordVan(~LordVan@gentoo/developer/lordvan) has joined #tryton | 07:05 | |
| LordVan | hi | 07:06 |
| LordVan | i got a question about invoice grouping | 07:06 |
| pokoli | ACTION waiting for LordVan to ask his question.... | 07:07 |
| LordVan | I did change _get_invoice_grouping_fields to include another (custom) field for grouping (i called it sale_group_name - so i can decide through a field on the sale/invoice which invoice I want to be grouping) | 07:07 |
| LordVan | but for some reason i got a problem now where when it is multiple shipments from the same customer it does not group them unless i make a sale amendment later (to force it to re-process) | 07:07 |
| LordVan | and if it is from multiple sales it won'T do it at all | 07:08 |
| LordVan | it had worked during tests before, but for some reason I ge6t this weird issue now | 07:08 |
| LordVan | the code is here: https://github.com/LordVan/tryton-modules/commit/9e375c964e0d90fc1cb7e1ab6cdc684247c17f74 | 07:10 |
| LordVan | (the patch includes a few things related to 6.4 -> 6.8 too but you get the idea i am sure) | 07:10 |
| LordVan | pokoli, any idea what I'm missing? | 07:18 |
| pokoli | LordVan: not probably related to the issue but you should always call super instead of rewriting the full _get_invoice_grouping_fields method | 07:20 |
| pokoli | so you get the list from super() and append the fields you add | 07:20 |
| pokoli | Like you do in create_invoice | 07:20 |
| LordVan | yeah i actually just noticed that myself.. just changed that one | 07:20 |
| pokoli | LordVan: you do not need to make and amendment, there is a process button on the sale | 07:20 |
| LordVan | pokoli, yes i know but i noticed an amedment does that too | 07:21 |
| pokoli | There should be an error somewhere. If you are on 6.8, you should see some record in Administration - > Scheduler -> Errors | 07:21 |
| LordVan | but not automatically and that is werid | 07:21 |
| LordVan | pokoli, aaah i found the error | 07:22 |
| LordVan | it is a custom fieldon the invoice that is required | 07:22 |
| LordVan | wait | 07:22 |
| LordVan | hmm i am not sure now .. that does nto show when the error happened? | 07:23 |
| LordVan | no never mind those were old errors .. there are none now .. hm | 07:25 |
| pokoli | LordVan: if you have a worker, sales are processed on background and errors not raised to the user but saved on errors table I mentioned earlier | 07:26 |
| LordVan | yes i had not actually needed that before so I forgot about it | 07:27 |
| LordVan | still i am not sure why my problem happens .. hmm | 07:28 |
| htgoebel | pokoli: re registry: Yes, anyhow this accepts a single version per package. Thus updating a dev package either requires to have some increasing version (e.g. based on mercurial revision count) or to delete the packake | 07:29 |
| htgoebel | pokoli: Uploading to some webspace (e.g. via ssh) seam much easer. | 07:30 |
| htgoebel | cedk: Would you accept a merge-request for uploading development versions to some place (using ssh)? Or some other kind of support to get trydevpi active again? | 07:30 |
| pokoli | htgoebel: it is possible to list and delete packages using gitlab api: https://docs.gitlab.com/ee/api/packages.html#delete-a-project-package | 07:32 |
| pokoli | So on each commit to default branch you can just delete and republish the same packages | 07:33 |
| pokoli | htgoebel: another problem when using the same package version is that you must use --no-cache when pip installing otherwise the packages will be installed from local cache if same version is used | 07:33 |
| LordVan | pokoli, btw here the data in question: https://dpaste.org/xuLGL | 07:37 |
| LordVan | so as you can see all the groupng fields are actually the same but it won'T group | 07:37 |
| LordVan | and i am out of ideas right now as to why | 07:37 |
| pokoli | LordVan: what happens if you delete both invoices? | 07:50 |
| pokoli | that will trigger the process of sale, recreate-them and they should be grouped | 07:50 |
| -!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton | 07:51 | |
| htgoebel | pokoli, cedk: I'm aware of the possibility to delete packages from the heptapod registry. Anyhow some "scp" command would be much easier. Esp. persmissions could be restricted to allow some ssh-key to only execute a single commans | 08:00 |
| pokoli | htgoebel: Maybe I'm missing something but how you install packages from scp ? | 08:01 |
| htgoebel | pokoli: I mean publishing by pushing it to some webspace-directory using scp | 08:04 |
| htgoebel | pokoli: Much like we do for the static website we both worked on a few weeks ago and push to your server | 08:05 |
| LordVan | pokoli, hmm let me try I guess | 08:06 |
| pokoli | htgoebel: but if you use a static website for packages you will need to indicate the full url to the package. If you use a pypi package (like the heptapod one) you will just need to indicate the package to install and pip will do all the magic | 08:06 |
| LordVan | actually to rule out any other issues let me comment out my custom method and try processing again to see what happens first | 08:07 |
| LordVan | ok that worked so it is that.. hmm | 08:09 |
| LordVan | pokoli, so this one line method is causing th eproblem but i am really not sure why .. https://github.com/LordVan/tryton-modules/blob/dd00adcad54f1a0aca4423ee0db3ffeed5432977/rm_extra_data/sale.py#L68 | 08:12 |
| LordVan | maybe because it is a varchar field - while all the other fields on the list are foreign keys ? | 08:13 |
| LordVan | no wait .. they are not .. 'state' is also char | 08:13 |
| htgoebel | pokoli: For a static web directory view one would only need to provide the link to the directory AFAIK as extra-index. pip would read directroy listing and fetch what it needs. I will validate this statement later today. | 08:25 |
| pokoli | htgoebel: yes but fetching from http is the same as fetching directly from the repository, you do no need to sync anything | 08:33 |
| htgoebel | pokoli: yes, but updating a directory on a static website is simpler than deleting the package in the repository, then uploading it again | 08:39 |
| pokoli | htgoebel: and downloading directly the monorepositoy is easier than a static website | 08:40 |
| pokoli | you won't need sync anything, just use the heptadpod sources for downloading your dependencies | 08:40 |
| htgoebel | pokoli: How can I make pip search for the package in the mono-repo. | 08:41 |
| -!- rpit(~rpit@p200300c88f19a400b629dc14e46bf803.dip0.t-ipconnect.de) has joined #tryton | 08:42 | |
| pokoli | htgoebel: https://www.tryton.org/~irclog/2023-09-28.log.html#t2023-09-28T10:27:46 | 08:42 |
| htgoebel | pokoli: AFAIU this, this requires to create a list of all package URLs first. | 08:47 |
| htgoebel | pokoli: When so look a the bottom of https://pip.pypa.io/en/stable/topics/vcs-support/#url-fragments this says pip install "pkg @ vcs+protocol://repo_url/#subdirectory=pkg_dir" | 08:48 |
| pokoli | htgoebel: the list of packages is already generated by setup.py requires | 08:49 |
| pokoli | you just need to use the custom URL instead of just the package name | 08:49 |
| htgoebel | pokoli: … which I read as: pip does not serch | 08:49 |
| htgoebel | pokoli: Using a custom url per package means that the CI needs to do much. much more when using a develop version. | 08:50 |
| htgoebel | pokoli: This is crap! | 08:51 |
| pokoli | htgoebel: I think its easier that CI does to much, than having an external process to sync everything which will be more error prone | 08:51 |
| pokoli | htgoebel: on the other hand, if you sync every day but just build once a month, the resources for sync are wasted ... | 08:52 |
| htgoebel | pokoli: Prior to switching to heptapod, trydevpi provided development packages. The same should be possible now. That's all I'm demanding. Everything else are implementation details | 08:57 |
| pokoli | htgoebel: trydevpi was provide because it was required for drone CI | 08:58 |
| pokoli | htgoebel: trydevpi is no longer required with heptapod, so it is no longer needed | 08:58 |
| pokoli | this is the reason why it is not available now | 08:58 |
| htgoebel | pokoli, cedk: Yeah, but this leaves alone that 3rd party developers may need development packages. Thus proving these IHMO is a task of the foundation: supporting the community and fostering Tryton. | 09:05 |
| htgoebel | pokoli, cedk: This is especially true since the infrastructure already exists. The only missing piece is the upload from heptapod CI - which I offered to provide | 09:05 |
| pokoli | htgoebel: If you want to provide a package index for development packages then just use the heptapod package registry | 09:11 |
| htgoebel | pokoli, cedk: Would you accept a merge-request for uploading development versions to the Tryton project's heptapod package registry? (Which will require to delete existing dev version packages from the repository) | 09:18 |
| pokoli | htgoebel: you should just ask cedk if he agrees with the design as I have no powers to accept anything | 09:24 |
| pokoli | But I think it will be better to start with a discuss topic explaining the full proposal and the exact needs. | 09:25 |
| pokoli | htgoebel: there is also https://foss.heptapod.net/tryton/tryton/-/issues/7736 which may solve the issue if you use docker for CI | 09:26 |
| -!- springwurm(~springwur@2a01:76c0:100:f500:a538:d39f:988d:f233) has joined #tryton | 11:54 | |
| -!- tbruyere(~Thunderbi@mail.saluc.com) has joined #tryton | 12:05 | |
| -!- nicoe(~nicoe@2a02:578:852a:c00:7e2a:31ff:fe5e:b25d) has joined #tryton | 13:38 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 15:11 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 15:11 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!