IRC logs of #tryton for Tuesday, 2023-12-05

irc.libera.chat #tryton log beginning Tue Dec 5 12:10:01 AM CET 2023
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton23:58
-!- ChanServ changed mode/#tryton -> +o cedk 23:58
-!- Pegasus_RPG(~Thunderbi@2600:4041:7a71:8100:b09e:31f9:52f3:598c) has joined #tryton01:03
-!- yangoon(~yangoon@pd9e4a09f.dip0.t-ipconnect.de) has joined #tryton02:55
-!- dotbit(~dotbit@dotbit.ro) has joined #tryton05:34
-!- springwurm(~springwur@2a01:76c0:100:f500:6438:a72f:d67:1d67) has joined #tryton06:32
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton07:14
-!- ChanServ changed mode/#tryton -> +o cedk 07:14
-!- mrichez(~Maxime@mail.saluc.com) has joined #tryton07:25
-!- mrichez(~Maxime@mail.saluc.com) has joined #tryton07:37
-!- yangoon(~yangoon@pd9e4addb.dip0.t-ipconnect.de) has joined #tryton07:57
-!- udono(~udo@071-154-117-131.ip-addr.inexio.net) has joined #tryton08:08
-!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton08:26
dotbitHi, I have added autocomplete+default_get in party_ro module from local fisc. I am trying to get it to a reasonable quality for including upstream, but I have ways to go.08:35
dotbithttps://foss.heptapod.net/tryton/tryton/-/blob/branch/default/modules/party/party.py#L34208:35
dotbitIt keeps bothering me why this function is defined, but I can not figure out how to reuse it when I redefine the classmethod in party_ro08:36
dotbitI do this:         values = super().default_get(fields_names, with_rec_name=with_rec_name)08:36
dotbitSorry, I meant         result = super().autocomplete(text, domain=domain, limit=limit, order=order)08:37
dotbitand also to reuse the identifier_types, etc08:37
cedkdotbit: you can not reuse it because it is in the scope of the method08:49
cedkyou have to write your own version08:50
dotbitcedk: I like the generic implementation in Model for autocomplete and default_get. Thank you for that.09:06
dotbitI think two features that could be added are wizzard to add new party from Parties, and also checking of existing parties.09:07
pokolidotbit: there is a wizard to merge duplicated parties09:08
dotbitRegarding checking of existing parties I am a little worried about the way we are mixing model defaults (ex. from config) and things added in default_get from authorative source.09:08
dotbitpokoli: you mean Replace?09:10
pokolidotbit: yes, the replace is used to fix duplicates09:13
dotbitcedk: understood, thank you09:22
dotbitin Romania I think we have something like siret, where the fiscal domicile of a company is linked to an address, it is the ro_onrc identifier.09:23
dotbitI am thinking it is a good idea to link that identifier to the address like siret, but I can not figure out where that is done inside party_siret09:24
dotbitpokoli: Maybe some functionality could be reused from there, maybe use it as an example.09:27
pokolidotbit: I do not know which is the usage of siret as its specific for france. But from what I see in a quick look in the code it just adds a Function field to show the identifiers of addresses09:28
pokoliIIRC the identifiers on the address have been moved to party module09:29
dotbitpokoli: ah, I was looking in the wrong place. it works even without party_siret activated once configured, so you must be right09:33
dotbitthank you Sergi!09:34
-!- acaubet1(~Thunderbi@194.224.31.235) has joined #tryton09:53
-!- Pegasus_RPG(~Thunderbi@2600:4041:7a71:8100:b09e:31f9:52f3:598c) has joined #tryton13:14
-!- springwurm(~springwur@2a01:76c0:100:f500:5c8f:8172:c579:de74) has joined #tryton13:18
-!- srgdts(~srgdts@user/srgdts) has joined #tryton17:56
-!- yangoon(~yangoon@p5dd084c6.dip0.t-ipconnect.de) has joined #tryton20:20

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!