| chat.freenode.net #tryton log beginning Fri Mar 23 00:00:01 CET 2012 | ||
| 2012-03-23 11:56 <marc0s> cedk: i found more or less what was my problem with the icons, no support for the icon format (svg) i suppose derived from the fact that my box has gtk3 and there may be some problem or colision with it. librsvg is installed btw | ||
| 2012-03-23 11:57 <cedk> marc0s: did the patch help? | ||
| 2012-03-23 11:58 <marc0s> cedk: yes, the client doesn't hang at startup and starts | ||
| 2012-03-23 11:58 <marc0s> cedk: it doesn't show any icon and fails when it raise the exception of unknown file format | ||
| 2012-03-23 11:59 <cedk> marc0s: could you put a comment on codereview | ||
| 2012-03-23 12:00 <cedk> marc0s: what do you mean by "exception of unknown file format"? | ||
| 2012-03-23 12:00 <marc0s> cedk: that was the error spited out in the shell | ||
| 2012-03-23 12:00 <marc0s> (more or less) | ||
| 2012-03-23 12:00 <marc0s> cedk: i don't remember the exception type itself | ||
| 2012-03-23 12:01 <marc0s> cedk: let me re-run it again and will comment on the CR with enough info | ||
| 2012-03-23 12:02 <cedk> marc0s: ok thx | ||
| 2012-03-23 12:03 <marc0s> cedk: the error http://paste.pocoo.org/show/569942/ | ||
| 2012-03-23 12:03 <marc0s> cedk: it says: cannot recognize the file format of the file | ||
| 2012-03-23 12:05 <cedk> marc0s: ok, I don't know if we should catch such error | ||
| 2012-03-23 12:05 <cedk> marc0s: because clearly your system is broken :-) | ||
| 2012-03-23 12:06 <marc0s> cedk: sure it is :) | ||
| 2012-03-23 12:08 <marc0s> cedk: what i'm not sure is, without applying the patch, if the error is raised by a not found issue or the same issue about the file format (in tryton2.0 the catched exception is Exception, not IOError) | ||
| 2012-03-23 12:24 <marc0s> cedk: the raised exception class is glib.GError so seems that the problem is because my b0rken system and not because a missing file | ||
| 2012-03-23 12:24 <marc0s> will write it down in the review | ||
| 2012-03-23 12:27 <cedk> marc0s: ok, I'm wondering if we should catch this exception | ||
| 2012-03-23 12:28 <marc0s> cedk: i'm not sure neither | ||
| 2012-03-23 12:33 <cedk> marc0s: did you do special stuff to break your system? | ||
| 2012-03-23 12:33 <marc0s> cedk: no that i remember, just keeping my system up to date (archlinux, gtk3 hanging around the system, ...) | ||
| 2012-03-23 12:34 <marc0s> cedk: maybe some system wide installed packages are now packaged for gtk3 and don't have support for gtk2 (i'm no expert at all on gtk so i don't know if it makes sense) | ||
| 2012-03-23 12:35 <cedk> marc0s: so others could have the same issue | ||
| 2012-03-23 12:37 <marc0s> cedk: seems possible | ||
| 2012-03-23 14:00 <cedk> marc0s: could you try with the last version of the patch | ||
| 2012-03-23 17:17 <marc0s> cedk: i've seen the patch, will try to test it during the weekend | ||
| 2012-03-23 17:20 <cedk> marc0s: ok | ||
| 2012-03-23 20:48 -!- Mayank(~mayank@122.162.67.107) has left #tryton |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!