| chat.freenode.net #tryton log beginning Sun Mar 3 00:00:02 CET 2013 | ||
| 2013-03-03 08:20 -!- ciupicri(~ciupicri@unaffiliated/ciupicri) has left #tryton | ||
| 2013-03-03 11:45 <jonan> Is this a possible bug ? In v2.6 when receiving an incoming supplier shipment and foreign currency exchange is involved the foreign currency amount is used in the account moves instead of company currency so inventory accounts are off. | ||
| 2013-03-03 13:15 <cedk> jonan: probably a bug | ||
| 2013-03-03 13:23 <jonan> just submitted bug 3036 | ||
| 2013-03-03 13:45 <cedk> jonan: I have wroten a patch | ||
| 2013-03-03 14:22 <jonan> cedk: Just tested out the patch. Working now. Thanks. | ||
| 2013-03-03 14:36 <albertca> cedk: In the constraint changes patch we cannot use record's rec_name when rising the exception | ||
| 2013-03-03 14:36 <albertca> cedk: because rec_name may try to render the full path (which is recursive) | ||
| 2013-03-03 14:37 <cedk> albertca: examples? | ||
| 2013-03-03 14:37 <albertca> cedk: webdav collection | ||
| 2013-03-03 14:37 <cedk> albertca: link? | ||
| 2013-03-03 14:37 <albertca> cedk: rec_name will try to print the full path "A / B / C" | ||
| 2013-03-03 14:39 <albertca> cedk: http://hg.tryton.org/trytond/file/a1827bf823d2/trytond/webdav/webdav.py#l79 | ||
| 2013-03-03 14:39 <cedk> albertca: I know rec_name | ||
| 2013-03-03 14:41 <albertca> cedk: http://codereview.tryton.org/371002/diff/72011/trytond/model/modelstorage.py | ||
| 2013-03-03 14:41 <albertca> cedk: as with consraint changes modelstorage.py raises the exception with record's rec_name it may crash with some models | ||
| 2013-03-03 14:42 <cedk> albertca: I still don't understand | ||
| 2013-03-03 14:42 <cedk> albertca: what is the link of the faulty code? | ||
| 2013-03-03 14:42 <albertca> cedk: the model storage one | ||
| 2013-03-03 14:43 <albertca> cedk: model storage will raise an exception using record's rec_name if the record is recursive | ||
| 2013-03-03 14:43 <albertca> cedk: but trying to print the rec_name will crash because it browses information to parent, grandparent, etc | ||
| 2013-03-03 14:44 <cedk> albertca: the code? | ||
| 2013-03-03 14:44 <albertca> cedk: those two links are enough :) | ||
| 2013-03-03 14:45 <albertca> cedk: the issue can be solved if in the check_recursion function we print the record's id | ||
| 2013-03-03 14:45 <albertca> cedk: but that is not relevant for the user | ||
| 2013-03-03 14:45 <cedk> albertca: they point to nothing! | ||
| 2013-03-03 14:45 <cedk> albertca: I can not speak if I don't see the *code* | ||
| 2013-03-03 14:46 <cedk> albertca: I will not read all modelstorage.py | ||
| 2013-03-03 14:47 <albertca> cedk: of course, but I don't know if I can point to a given line in a codereview | ||
| 2013-03-03 14:47 <albertca> cedk: it is in line 851 | ||
| 2013-03-03 14:51 <cedk> albertca: so use the id | ||
| 2013-03-03 14:51 <albertca> cedk: that's what I did :) | ||
| 2013-03-03 14:52 <albertca> cedk: do you think we could let the programmer use any field of the model? | ||
| 2013-03-03 14:52 <albertca> cedk: Such as "%(name)s" and we replace with the field name of the model | ||
| 2013-03-03 14:52 <cedk> albertca: or improve rec_name to detect loop but it is a little bit against the constrint | ||
| 2013-03-03 14:52 <albertca> cedk: yes, I didn't want to do loop detection in there | ||
| 2013-03-03 14:53 <albertca> cedk: another idea would be to catch the exception and raise it correctly from the inheriting model | ||
| 2013-03-03 14:54 <cedk> albertca: why not having a rec_name params | ||
| 2013-03-03 14:54 <cedk> albertca: also I think it is good to show the name of the parent field | ||
| 2013-03-03 14:54 <albertca> cedk: what do you mean with rec_name params? | ||
| 2013-03-03 14:55 <cedk> albertca: …, parent='parent', rec_name='rec_name') | ||
| 2013-03-03 14:56 <albertca> cedk: ok, sounds good to me | ||
| 2013-03-03 14:57 <albertca> cedk: will change that and update the patch today | ||
| 2013-03-03 14:59 <cedk> albertca: ok, should no more wait to be included in next release | ||
| 2013-03-03 15:11 <albertca> cedk: yes, I know |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!