chat.freenode.net #tryton log beginning Tue May 28 00:00:02 CEST 2013 | ||
bigato | hi guys | 02:52 |
---|---|---|
bigato | bye guys | 03:13 |
bigato | :-) | 03:13 |
sharoonthomas | running tests using sqlite as database (with python std lib sqlite module), the transactions seem to be committed even when there are user errors | 11:25 |
sharoonthomas | digging more into the issue it seems like the python sqlite3 library does automatic commits | 11:25 |
sharoonthomas | is this a known issue ? | 11:25 |
cedk | sharoonthomas: not by me | 11:42 |
sharoonthomas | cedk: checked with the party test for party.code and I can confirm that commits happen | 11:42 |
sharoonthomas | http://stackoverflow.com/questions/13642956/commit-behavior-and-atomicity-in-python-sqlite3-module | 11:42 |
cedk | sharoonthomas: in the code we set isolation_level to None | 11:42 |
sharoonthomas | cedk: it is not a problem with tryton code, but a limitation of the std lib sqlite3 | 11:43 |
sharoonthomas | cedk: looks like a serious issue for neso users, though tests could be misguiding too | 11:43 |
cedk | sharoonthomas: http://docs.python.org/2/library/sqlite3.html#sqlite3.Connection.isolation_level | 11:45 |
cedk | sharoonthomas: indeed by default it is IMMEDIATE | 11:45 |
cedk | sharoonthomas: so normally it is like if a BEGIN is always set | 11:46 |
sharoonthomas | cedk: ok, so is it not a bug to have isolation_level set to None, because that is the auto commit mode | 11:47 |
cedk | sharoonthomas: it is set to IMMEDIATE by default | 11:48 |
sharoonthomas | cedk: yes it is (https://github.com/openlabs/trytond/blob/master/trytond/backend/sqlite/database.py#L146) | 11:49 |
sharoonthomas | cedk: will debug more and let you know | 11:49 |
cedk | sharoonthomas: ok | 11:53 |
sharoonthomas | cedk: looked deeper: it's because there was an assertRaises which looked for an expected UserError, but the test continued from there without issuing a rollback | 12:05 |
sharoonthomas | cedk: moving it to a separate transaction solved the problem | 12:06 |
sharoonthomas | cedk: sorry for the confusion | 12:06 |
cedk | sharoonthomas: ok | 12:08 |
cedk | sharoonthomas: is it in trytond ? | 12:08 |
sharoonthomas | cedk: no, in a customer module | 13:18 |
sharoonthomas | who is the admin in the linked in group called "tryton" ? | 13:42 |
cedk | sharoonthomas: I think I'm | 13:55 |
sharoonthomas | cedk: are you allowed to flag content ? or remove them ? | 13:56 |
cedk | sharoonthomas: I think | 13:56 |
sharoonthomas | cedk: not sure what is the policy on removal, but i think you should remove the unsolicited Open ERP marketing on the group: https://www.linkedin.com/groups/synconics-blogpost-http-synconicsblogspotin-2013-1313967.S.244316862?qid=40640726-b8e3-455f-ab2a-421fa3467c0e&trk=group_most_popular-0-b-ttl&goback=%2Egmp_1313967 | 13:57 |
cedk | sharoonthomas: I can find the post | 14:12 |
cedk | sharoonthomas: think the link doesn't work | 14:13 |
sharoonthomas | it says its no longer available | 14:13 |
sharoonthomas | probably automatically removed because of too many flags or the authors decided to remove themselves | 14:14 |
cedk | sharoonthomas: ok | 14:14 |
joac | hi, exists some uml, or class diagram or something like this for trytond? Im analizing the architecture and trying to understand the internals | 17:26 |
smarro | joac: go to Administration -> Models -> Models, select a model a print Graph | 17:30 |
joac | smarro: thanks! | 17:36 |
-!- ZipBreake(~mergo@5-39-79-103.net.comusys.net) has left #tryton | 21:07 |
Generated by irclog2html.py 2.11.0 by Marius Gedminas - find it at mg.pov.lt!