| chat.freenode.net #tryton log beginning Tue 17 Dec 2019 12:00:01 AM CET | ||
| -!- thaneor(~lenovo3@r167-56-50-232.dialup.adsl.anteldata.net.uy) has joined #tryton | 00:19 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 00:41 | |
| -!- yangoon(~mathiasb@238-152-142-46.pool.kielnet.net) has joined #tryton | 03:21 | |
| -!- scrapper(~scrapper@mx.develissimo.com) has joined #tryton | 05:17 | |
| -!- springwurm(~Springwur@5.104.149.54) has joined #tryton | 06:03 | |
| -!- semarie(~semarie@unaffiliated/semarie) has joined #tryton | 06:59 | |
| -!- mrichez(~Maxime@mail.saluc.com) has joined #tryton | 07:25 | |
| -!- rpit(~rpit@p200300C88F32F600A22070230F535743.dip0.t-ipconnect.de) has joined #tryton | 07:52 | |
| -!- nicoe(~nicoe@2a02:578:852a:c00:7e2a:31ff:fe5e:b25d) has joined #tryton | 08:09 | |
| -!- josesalvador(~josesalva@84.124.29.26.static.user.ono.com) has joined #tryton | 08:11 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 08:31 | |
| -!- nicoe(~nicoe@2a02:578:852a:c00:7e2a:31ff:fe5e:b25d) has joined #tryton | 08:44 | |
| -!- jani-matti_(~quassel@93-90-53-6.welcomnet.fi) has joined #tryton | 09:04 | |
| -!- buxy_bak(~rhertzog@helios.freexian.com) has joined #tryton | 09:08 | |
| -!- paolo_(~paolo@unaffiliated/paolo) has joined #tryton | 09:09 | |
| -!- mniip(mniip@freenode/staff/mniip) has joined #tryton | 09:16 | |
| -!- thaneor(~lenovo3@r179-24-37-117.dialup.adsl.anteldata.net.uy) has joined #tryton | 09:17 | |
| -!- sisalp(~sisalpuse@51.sisalp.net) has joined #tryton | 09:18 | |
| -!- nicoe(~nicoe@2a02:2788:54:5a3:7e2a:31ff:fe5e:b25d) has joined #tryton | 09:40 | |
| -!- buxy_bak(~rhertzog@helios.freexian.com) has left #tryton | 09:42 | |
| -!- springwurm(~Springwur@5.104.149.54) has joined #tryton | 10:07 | |
| mrichez | hi, when a user log into tryton (5.2 - windows client) he get this error : 429 TOO MANY REQUESTS ( here's the full error message: https://pastebin.com/QEF0C9B2) then the client quit. I saw this subject on discuss: https://discuss.tryton.org/t/how-to-manage-this-error-fault-fault-429-too-many-requests/896 . But wondering why there's such error message instead of a clean warning "Too much erroneous attempts..." ? | 10:55 |
|---|---|---|
| cedk | mrichez: because it is low level protection | 10:57 |
| cedk | we return the HTTP status corresponding to such problem | 10:58 |
| mrichez | cedk: because user doesn't know what to d and is calling us... | 10:58 |
| cedk | now maybe the client could display a better message | 10:58 |
| mrichez | cedk : and he doesn't know how long he must wait before to log on successfully | 10:59 |
| cedk | mrichez: but normally it should not happen except if user are forgetting their passwords or you are under brute force attack | 10:59 |
| mrichez | cedk: don't know how many attempts he did | 10:59 |
| -!- mariomop(~quassel@181.228.29.59) has joined #tryton | 11:01 | |
| cedk | mrichez: well it is the first thing to collect to see if it is unusual or not | 11:05 |
| mrichez | cedk: ok will investigate :-) | 11:06 |
| mrichez | cedk: often is just a problem of uppercase/lowercase so they try many attempts before to remark | 11:07 |
| cedk | mrichez: you should have the attempt recorded in the database | 11:07 |
| mrichez | cedk: ok will check | 11:07 |
| mrichez | cedk: in which table ? | 11:08 |
| cedk | mrichez: res_user_login_attempt | 11:09 |
| mrichez | cedk: ok 16 attempts .. :-) i understand | 11:10 |
| cedk | mrichez: the best is to get user open the URL with the database name as hashtag so his session will still be stored in the browser and he will not need to login | 11:15 |
| mrichez | cedk: we use gtk client | 11:16 |
| cedk | then it is education: not type 16 times the same wrong password | 11:18 |
| mrichez | cedk: indeed :-) | 11:33 |
| -!- nicoe(~nicoe@host-85-201-184-151.dynamic.voo.be) has joined #tryton | 11:34 | |
| cedk | mrichez: I think we could improve the UX by doing login asynchronous so the watch cursor will be displayed and the user may cancel the process (and close the application) | 11:49 |
| mrichez | cedk: and how can i let user login again ? clearing the table ? | 11:50 |
| cedk | I think it will reduce the case that user may think the application was not responding | 11:50 |
| mrichez | cedk: in our case, an error message is displayed (no delay) | 11:51 |
| cedk | mrichez: this is because he tried more than 5 times | 11:52 |
| cedk | mrichez: so you can clear the attempt table | 11:52 |
| cedk | otherwise hi account is blocked for the session timeout seconds | 11:53 |
| mrichez | cedk: ok.. will do that... may be the ux can switch to let user see the password to check if it's correct ? or displaying an icon if uppercase is active ? | 11:53 |
| cedk | 5 minutes by default | 11:53 |
| cedk | indeed we should have show password on the login like on password widget | 11:54 |
| mrichez | cedk: would be useful | 11:55 |
| mrichez | cedk: added https://bugs.tryton.org/issue8934 | 12:35 |
| -!- nicoe(~nicoe@2a02:2788:54:5a3:7e2a:31ff:fe5e:b25d) has joined #tryton | 13:01 | |
| -!- springwurm(~Springwur@5.104.149.54) has joined #tryton | 13:05 | |
| -!- amprxc(b97aa1f7@gateway/web/cgi-irc/kiwiirc.com/ip.185.122.161.247) has joined #tryton | 13:08 | |
| mrichez | is there a way to unset a default value on copy ? I try to keep sale_date when copying a sale (but it is set to None by default)... | 13:15 |
| pokoli | mrichez: normally supper calls use setdefault so if you have the 'sale_date' value set in the defaults parameter of copy it should not be overriden to default | 13:52 |
| pokoli | mrichez: this is the case of the sale_date https://hg.tryton.org/modules/sale/file/8b5b19274cb4/sale.py#l666 | 13:52 |
| pokoli | mrichez: so setting the date you want on the defaults parameter of copy will preserve it | 13:52 |
| pokoli | mrichez: you just need to override the function on your custom module and set the default value before calling super() | 13:53 |
| mrichez | pokoli: but i don't want to set sale_date to default... i want to keep original value... | 13:55 |
| pokoli | mrichez: then you can set a function that returns the default value | 13:56 |
| pokoli | s/default value/original value/ | 13:57 |
| pokoli | mrichez: https://docs.tryton.org/projects/server/en/latest/ref/models/models.html#trytond.model.ModelStorage.copy | 13:58 |
| pokoli | mrichez: see https://hg.tryton.org/trytond/rev/aabb2b3e5096/#l7.33 for an example | 13:58 |
| mrichez | pokoli: when i will call super, even if i set a default value, it will be overwritten by the default value in the copy defined in sale ? | 14:00 |
| pokoli | mrichez: no because setdefault function only overrides the value if not set | 14:00 |
| mrichez | pokoli: ok :-) | 14:00 |
| mrichez | pokoli: ok working . Thanks! :-) https://pastebin.com/FX04gJCU | 14:20 |
| mrichez | pokoli: wondering the behaviour if i duplicate multiple sales having different date, i thought all the duplicate sales would have the same first date, but each sale is duplicated with the correct date | 14:21 |
| pokoli | mrichez: yes, that because the function is called for each record to set the values | 14:23 |
| mrichez | pokoli: as the parameter of the copy function is "sales", i thought it was all the selected records | 14:23 |
| pokoli | mrichez: yes sales contain all the selected records, but the function is called for each record with data as the values of the original one | 14:24 |
| cedk | mrichez: by the way, I created https://bugs.tryton.org/issue8935 to display a nicer message on too many request | 14:24 |
| mrichez | pokoli: thanks for the explanations | 14:25 |
| mrichez | cedk: ok, will be better for the users | 14:26 |
| -!- nicoe(~nicoe@host-85-201-184-151.dynamic.voo.be) has joined #tryton | 14:31 | |
| -!- josesalvador(~josesalva@170.253.41.74) has joined #tryton | 14:50 | |
| mrichez | how to have a trace with tryton gtk client under windows 10... i've a problem with a @modelview.button_action , when i click on the button nothing happens ... it should display a report... it's working on linux | 15:29 |
| mrichez | just saw discuss about that: https://discuss.tryton.org/t/logging-of-desktop-client-for-windows/2075 | 15:33 |
| sisalp | Hello, On 5.4 I try to block sale document translation. Setting the flag on report form doesn't seem to do it. Fields of my command are still translated to customers language. Is it expected ? | 15:38 |
| sisalp | I mean unsetting the "translatable" flag. | 15:40 |
| cedk | sisalp: the flag is only to generate or not the translation entries | 15:43 |
| mrichez | I made another test - button handle_shipment_exception... nothing happens... it seems Modelview.button_action is not working on latest gtk client for windows 64 bit (this version: http://www.b2ck.com/~ced/tryton-5.5.dev0.exe) Can anyone confirm ? | 15:45 |
| cedk | sisalp: I think this flag should also disable the translation in Report | 15:45 |
| cedk | sisalp: filled https://bugs.tryton.org/issue8937 | 15:50 |
| sisalp | cedk: thank you. | 15:55 |
| sisalp | I have another question : when I add a line to a draft sale order, the product description doesn't come to line description. Dio I miss something ? | 15:57 |
| cedk | sisalp: no it is the expected behavior | 15:59 |
| cedk | sisalp: if you want to display product description on the report just display it. | 15:59 |
| cedk | there is no point to duplicate the data on the sale line | 15:59 |
| sisalp | cedk: I will modify the report and check | 16:04 |
| sisalp | cedk: works well indeed. Another point is about font. I thought about using Liberation sans narrow. It seems I don't have it and it is probably complex to add it. What is the situation ? | 16:18 |
| cedk | sisalp: I do not understand | 16:22 |
| sisalp | cedk: When I edit my sale.fodt template, I choose Liberation sans narrow for a paragraph, and it is changed to Liberation sans in the final document. | 16:25 |
| -!- springwurm(~Springwur@5.104.149.54) has joined #tryton | 16:27 | |
| sisalp | cedk: probably related to my libreoffice installation: on odf result, I keep my font, and I loose it the pdf translation. I will play on the size for now. | 16:31 |
| cedk | sisalp: I guess the server which does the pdf conversion does not have the font | 16:32 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!