| irc.libera.chat #tryton log beginning Mon Sep 27 12:00:02 AM CEST 2021 | ||
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 22:29 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 22:29 | |
| -!- springwurm(~springwur@5.104.149.54) has joined #tryton | 05:09 | |
| -!- mrichez(~Maxime@2a02:a03f:c2e8:f900:ed77:85ea:af2b:ba6e) has joined #tryton | 05:57 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 06:45 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 06:45 | |
| -!- timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton | 06:53 | |
| -!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton | 06:59 | |
| -!- nicoe(~nicoe@2a02:578:852a:c00:18c2:1aff:fef9:2b7f) has joined #tryton | 07:05 | |
| -!- udono(~udono@138-136-067-156.ip-addr.inexio.net) has joined #tryton | 07:56 | |
| -!- rpit(~rpit@p200300c88f168d000ae81a7497341a2e.dip0.t-ipconnect.de) has joined #tryton | 09:59 | |
| -!- nicoe(~nicoe@2a02:578:852a:c00:18c2:1aff:fef9:2b7f) has joined #tryton | 10:43 | |
| -!- springwurm(~springwur@5.104.149.54) has joined #tryton | 12:05 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 12:07 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 12:07 | |
| mrichez | hi, just testing sale_shipment_cost module. On a sale, if i choose Invoice Method: "on order processed" and Shipment Cost Method: "on shipment", should the shipment cost added on invoice when shipment is done? | 12:55 |
|---|---|---|
| cedk | mrichez: try it? | 13:03 |
| mrichez | yes not working... | 13:03 |
| mrichez | wondering if state is correct here : https://hg.tryton.org/modules/sale_shipment_cost/file/tip/sale.py#l314 | 13:03 |
| cedk | mrichez: what is not working? | 13:06 |
| mrichez | my shipment cost is not on the invoice... forget my previous line about state (state is "sent" in sale, but "done" on shipment) anyway invoice line concerning shipment is not created (tests done in version 6.0) | 13:07 |
| mrichez | tested also on demo6.0.tryton.org, no invoice for shipment (if shipment_cost_method is "on shipment"- | 13:10 |
| cedk | I think this is expected with such configuration | 13:12 |
| cedk | if you create the invoice when the order is validated, there is no shipment yet done so there is no cost computed | 13:12 |
| cedk | so for me the system works as expected | 13:13 |
| mrichez | indeed, but i thought shipment cost are added to invoice when shipment is done ? | 13:13 |
| mrichez | or shipments cost should generate another invoice | 13:14 |
| mrichez | so why adding shipment costs ? | 13:14 |
| mrichez | yes it's for margin but for invoicing too | 13:15 |
| cedk | indeed create_invoice does not create an invoice only for the shipment cost | 13:17 |
| mrichez | cedk: bug or feature ? | 13:18 |
| cedk | but I don't like to create an invoice in sub-module | 13:22 |
| cedk | I'm wondering if we should not have a unique constraint par sale on shipment_cost | 13:23 |
| cedk | and compute the shipment cost invoice line in _get_invoice_line_quantity also when the method is shipment | 13:24 |
| cedk | so it would be a new behavior | 13:24 |
| mrichez | ok | 13:28 |
| mrichez | another question about this module: 2 fields are visible on shipment form after carrier : cost and cost_sale... cost_sale is used on the invoice and cost is for the margin. but cost_sale will be on the invoice only if cost is not zero. It could be possible to have a shipment "free" cost and invoice something to customer, no ? | 13:33 |
| cedk | yes this is probably a mistake and cost_sale should be tested | 13:36 |
| mrichez | ok | 13:37 |
| mrichez | cedk: it's here, shipment should have a cost: https://hg.tryton.org/modules/sale_shipment_cost/file/tip/sale.py#l316 . Could this test bypassed ? | 14:28 |
| cedk | mrichez: I guess yes if get_cost_invoice_line does not return a line for 0 | 14:40 |
| mrichez | cedk: if no cost_sale no line is returned : https://hg.tryton.org/modules/sale_shipment_cost/file/tip/stock.py#l106 | 14:42 |
| cedk | mrichez: so I think the test should be removed | 14:46 |
| mrichez | cedk: ok | 14:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!