| chat.freenode.net #tryton log beginning Thu Jun 13 00:00:03 CEST 2013 | ||
| 2013-06-13 08:35 <mrechte> Hello. The Balance Sheet is a hierarchical tree view of Account Types (marked as balance sheet), is not it ? So I may be expecting the same hierarchy than for the Account Types view ? | ||
| 2013-06-13 09:06 <cedk> mrechte: yes | ||
| 2013-06-13 09:08 <mrechte> cedk: ok, so it seems to me the domain is not correct in act_account_balance_sheet_tree: it should rather be [('balance_sheet', '=', True), ('parent', '=', False)] | ||
| 2013-06-13 09:10 <cedk> mrechte: why ? | ||
| 2013-06-13 09:16 <mrechte> cedk: to be consistent with the Account Types tree view, and to have each account only appearing once in the view | ||
| 2013-06-13 09:16 <cedk> mrechte: you must set balance_sheet to True only on top | ||
| 2013-06-13 09:17 <cedk> mrechte: ok I see there is a mistake in account_fr | ||
| 2013-06-13 09:23 <cedk> mrechte: or we could use: [('balance_sheet', '=', True), ['OR', ('parent', '=', None), ('parent.balance_sheet', '=', False)]] | ||
| 2013-06-13 09:23 <cedk> mrechte: could you test this | ||
| 2013-06-13 09:50 <mrechte> cedk: I already tested [('balance_sheet', '=', True), ('parent', '=', False)], which is OK providing the root is ticked as 'balance sheet'. I don't understand your alternative. | ||
| 2013-06-13 09:51 <cedk> mrechte: because balance_sheet is not necessary the root | ||
| 2013-06-13 09:52 <cedk> mrechte: and I can not see how your solution could work on account_fr | ||
| 2013-06-13 09:56 <mrechte> cedk: Just ticked the balance_sheet on the root account type (French Account Type Chart) | ||
| 2013-06-13 09:58 <cedk> mrechte: but in some way, "Hors bilan" should not be in balance sheet | ||
| 2013-06-13 09:58 <cedk> mrechte: so your test is not valid | ||
| 2013-06-13 10:04 <mrechte> cedk: OK, I tested with your suggestion. It seems the result is the same except I don't see the root, but the "Hors bilan" is still shown. | ||
| 2013-06-13 10:05 <cedk> mrechte: yes "Hors bilan" is set as balance_sheet but I think it should not | ||
| 2013-06-13 10:09 <mrechte> cedk: OK. By the way, none account is marked as income_statement in the French Chart. | ||
| 2013-06-13 10:09 <cedk> mrechte: could you make an issue with all issues about account_fr? | ||
| 2013-06-13 10:10 <mrechte> cedk: OK. | ||
| 2013-06-13 10:11 <cedk> mrechte: and maybe talk about it on french ML | ||
| 2013-06-13 10:27 <shalabhaggarwal> Hi, i am writing tests for tryton 2.8 where each test case is different and there are no commits in between but after 2-3 test cases, the tests break asking for account payable while creating the company's party. the same thing works fine for 2.4. I am wondering if some issue has been introduced in 2.6 or later. | ||
| 2013-06-13 10:31 <cedk> shalabhaggarwal: I guess you hit the removal of inherits | ||
| 2013-06-13 10:31 <cedk> shalabhaggarwal: so account properties are on the party of the company | ||
| 2013-06-13 10:32 <shalabhaggarwal> cedk: I think i am handling that correctly | ||
| 2013-06-13 10:32 <shalabhaggarwal> cedk: i will send over a small snippet which breaks for account_invoice module | ||
| 2013-06-13 10:35 <shalabhaggarwal> https://gist.github.com/shalabhaggarwal/5772141 | ||
| 2013-06-13 10:41 <cedk> shalabhaggarwal: I guess it is because you are updating the global CONTEXT | ||
| 2013-06-13 11:07 <shalabhaggarwal> cedk: the issue persists if i remove the context updating for the user on line 97 | ||
| 2013-06-13 11:10 <cedk> shalabhaggarwal: of course because you need a correct context | ||
| 2013-06-13 11:10 <cedk> shalabhaggarwal: but updating it like you do breaks the isolation of each tests | ||
| 2013-06-13 11:24 <mrechte> With the GTK client, would be possible to by default show records in read-only mode, and have a button to explicitly toggle in write mode ? | ||
| 2013-06-13 12:14 <shalabhaggarwal> cedk: thanks, figured it out | ||
| 2013-06-13 12:16 <cedk> mrechte: I think someone already asked that | ||
| 2013-06-13 12:17 <cedk> mrechte: but don't think it was kept as a good idea | ||
| 2013-06-13 12:43 <mrechte> cedk: it could be a config option. | ||
| 2013-06-13 12:51 <cedk> mrechte: talking about option is not something that can convince me :-) | ||
| 2013-06-13 12:52 <cedk> sisalp: could you check: https://bugs.tryton.org/issue3259 | ||
| 2013-06-13 15:54 <sisalp> mrechte: cedk: can we comment on #tryton-fr ? | ||
| 2013-06-13 15:55 <cedk> sisalp: oui | ||
| 2013-06-13 18:46 <pokoli> Hi all, how can I push a codereview affecting multiple modules? | ||
| 2013-06-13 18:46 <cedk> pokoli: you can use hgreview with option -n | ||
| 2013-06-13 18:49 <pokoli> cedk: thanks for fast response. Worked perfectly! |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!