IRC logs of #tryton for Monday, 2016-06-27

chat.freenode.net #tryton log beginning Mon Jun 27 00:00:01 CEST 2016
-!- miknotauro(~miknotaur@187.207.59.241) has joined #tryton04:30
-!- frispete_(~frispete@p54A90192.dip0.t-ipconnect.de) has joined #tryton05:25
-!- Michale(caa0a538@gateway/web/freenode/ip.202.160.165.56) has joined #tryton06:10
Michalehello, anyone can help me for JSON RPC call?06:18
-!- HoloIRCUser3(holoirc@nat/iiit/x-szajrngcohrkbfts) has joined #tryton07:13
-!- prayashm(~prayashm@unaffiliated/prayashm) has joined #tryton07:41
-!- rpit(~rpit@2a02:908:e672:9420:56ee:75ff:fe0d:d3c7) has joined #tryton08:11
Michaleanyone know about JSON RPC in triton?08:23
Michaletryton*?08:23
-!- dj_xatra(~dj_xatra@217.166.83.130) has joined #tryton08:37
-!- tbruyere(~smuxi@mail.saluc.com) has joined #tryton08:40
Michalehello09:01
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton09:09
-!- Timitos(~kpreisler@2001:a61:2187:fe01:ae7b:a1ff:feaf:55f0) has joined #tryton09:11
pokoliMichale: hello, could you explain what are you trying to achieve with JSON-RPC and whats problems/doubts do you have?09:12
-!- mrichez(~smuxi@mail.saluc.com) has joined #tryton09:12
shroxedk: I have done three of the five things you asked me to. Namely, removed the global variables, replaced concatenation with string format % and replaced classes with functions. I'm skeptical about the other two. Can you guide me how I should proceed with 1) creating the manifest file directly without reading the file list after they have been made. 2) handling images while making content.xml instead of reading it again.09:20
shroxcedk:09:21
cedkshrox: for the manifest, you could have an object that you call each time you add a new file to the zip09:25
pokolihi prayashm, could you explain the concurrency issue you have with deeper levels? What's the problem?09:25
cedkshrox: there is something similar in relatorio also for the Manifest09:26
cedkshrox: indeed you could maybe re-use it09:26
shroxcedk: Oh, that would be cool. I'll have a look.09:26
cedkshrox: for the image, when you remove it from the content, you could directly add them in the zip09:27
prayashmpokoli: https://github.com/prayashm/sao/blob/488425f48e33e876aa8dedc63cd08157afd10283/src/window.js#L108309:28
prayashmpokoli: when calling on_row_expanded, it needs to wait till the following <ul> is populated09:28
shroxcedk: How would I manage the various attributes (href, simple, show, actuate)? And since I am splitting the files one after the other, won't there be unnecessary code related to the images while the function primary splits files?09:29
pokoliprayashm: so you need a promise and add the code as callback of that promise09:29
pokoliprayashm: get_fields returns a promise, doesn't it?09:29
prayashmpokoli: get_fields does09:29
cedkprayashm: I think you must do recursion using callback09:30
prayashmpokoli: I should have another promise inside on_row_expanded or within auto_detect?09:30
cedkshrox: I think you must almost have a single function to read only once the file09:31
cedkshrox: it is bad for performence to parse again the XML09:32
prayashmcedk: you mean, I should replace the current while loop with recursive callbacks?09:32
cedkprayashm: yes I think09:32
prayashmcedk: it will differ from the code in gtk client then, isn't it?09:33
shroxcedk: Okay, how about if I make another function specifically for the body tag in content.xml? That can split the file as well as convert the binary data to the images.09:34
cedkprayashm: yes but async in JS is different09:35
cedkshrox: why not09:37
shroxcedk: I shall do that then. Thanks!09:38
cedkshrox: I think you can also have images in the styles file if you put an image in the header/footer09:38
cedkby the way how is it possible to comment code on GitHub?09:38
shroxcedk: Oh, I didn't know that. So I shall separate the both of them then.09:39
cedkshrox: you must check before09:39
pokolicedk: yes, but AFAIK you have to add the comment on the commit that added those line09:39
cedkpokoli: that's stupid09:40
cedkI can not spend time to find commit09:40
prayashmcedk: I will do that09:40
prayashmcedk: Click on the commit id09:40
cedkshrox, prayashm: you should start creating *real* review09:40
shroxcedk: Okay. Should I add what I have right now as a review?09:41
pokolicedk: there is a blame button may help you find the commit09:41
cedkpokoli: if UI is poor for review, it is. We have better tools09:43
prayashmcedk: okay09:44
cedkshrox: it is better that you try to integrate with the existing code before09:44
shroxcedk: If there are any specific code related comments, won't it be easier if I can get to know them now?09:46
cedkshrox: it will be easier on codereview09:49
shroxcedk: Yes, I meant, if I put this code on codereview right now, I can have a look at your comments. Later I could submit another review after integration.09:50
cedkshrox: of course but just always use the same review09:51
shroxcedk: Oh, okay. I shall do that now then, after making a few changes.09:52
-!- tbruyere(~smuxi@mail.saluc.com) has joined #tryton09:59
-!- shrox(shrox@nat/iiit/x-tenxnpckpqqaxqyw) has joined #tryton09:59
-!- meigallodixital(~meigallod@249.135.116.91.static.reverse-mundo-r.com) has joined #tryton10:00
-!- shrox(shrox@nat/iiit/x-jbojedgjxnozpmoa) has joined #tryton10:00
-!- yangoon_rm(~mathiasb@137.158.23.34) has joined #tryton10:06
-!- prak(7ab10e15@gateway/web/freenode/ip.122.177.14.21) has joined #tryton10:16
prakhi, I have been tryting to run Trytond 4.1 on Mac... I am getting "Could not connect to server"10:16
prakany ideas ?10:17
prak*trying10:17
prakI am using Postgres from postgresapp.com..will it make any difference ?10:18
pokoliprak: are you sure trytond server is running an you are connecting on the correct port10:23
prayashmWhile submitting for review, with command: upload.py --rev upstream/develop, I encounter an error saying "Got error status from 'git show 02e799...' "10:23
pokoliprak: also starting the server with --verbose flag will give you more information10:23
cedkprayashm: can not help on git10:43
cedkprayashm: you should try to use the hash10:50
-!- Timitos(~kpreisler@aftr-185-17-207-161.dynamic.mnet-online.de) has joined #tryton10:55
-!- Michael_(caa0a538@gateway/web/freenode/ip.202.160.165.56) has joined #tryton10:59
-!- udono(~udono@ip-37-201-245-214.hsi13.unitymediagroup.de) has joined #tryton10:59
-!- nicoe(~nicoe@host-85-201-184-151.dynamic.voo.be) has joined #tryton11:34
-!- mariomop(~quassel@181.91.135.146) has joined #tryton12:36
-!- yangoon_rm(~mathiasb@137.158.23.34) has joined #tryton13:25
-!- yangoon_rm(~mathiasb@137.158.23.34) has joined #tryton15:21
-!- kstenger(~karla@r179-24-187-110.dialup.adsl.anteldata.net.uy) has joined #tryton16:06
-!- kstenger(~karla@r179-24-187-110.dialup.adsl.anteldata.net.uy) has joined #tryton16:35
-!- JosDzG(~Thunderbi@fixed-203-141-189-203-141-123.iusacell.net) has joined #tryton17:06
-!- bvillasanti(~bvillasan@138.117.21.154) has joined #tryton17:38
-!- faviod(~faviod@190.108.228.120) has joined #tryton17:46
-!- JosDzGx(~Thunderbi@fixed-203-141-189-203-141-123.iusacell.net) has joined #tryton18:54
-!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton18:57
-!- faviod_(~faviod@190.108.228.120) has joined #tryton19:29
-!- kstenger1(~karla@r186-50-23-161.dialup.adsl.anteldata.net.uy) has joined #tryton20:19
-!- miknotauro(~miknotaur@187.207.59.241) has joined #tryton20:48
-!- apostatize(~visavis@unaffiliated/apostatize) has joined #tryton21:15
-!- nicoe(~nicoe@2a02:a03f:302d:1400:ee55:f9ff:fe7b:f7ac) has joined #tryton21:47
-!- yangoon_rm(~mathiasb@137.158.23.34) has joined #tryton21:47
-!- yangoon_rm(~mathiasb@137.158.23.34) has joined #tryton22:30
-!- faviod(~faviod@190.108.228.120) has joined #tryton23:08

Generated by irclog2html.py 2.11.0 by Marius Gedminas - find it at mg.pov.lt!