IRC logs of #tryton for Wednesday, 2016-10-26 #tryton log beginning Wed Oct 26 00:00:01 CEST 2016
-!- JosDzG(~Thunderbi@ has joined #tryton00:05
-!- robink_(~quassel@unaffilated/robink) has joined #tryton03:22
-!- Pilou( has joined #tryton03:25
-!- Pilou(~Pilou@pdpc/supporter/active/pilou) has joined #tryton03:25
-!- JosDzG(~Thunderbi@ has joined #tryton04:51
-!- JanGB( has joined #tryton07:49
-!- dj_xatra(~dj_xatra@ has joined #tryton07:50
-!- rpit(~rpit@2a02:908:e672:1520:56ee:75ff:fe0d:d3c7) has joined #tryton08:14
-!- Timitos( has joined #tryton08:40
-!- mrichez( has joined #tryton08:51
-!- g5pw(~g5pw@mittelab/sudo/g5pw) has joined #tryton08:58
-!- nicoe(~nicoe@2a02:a03f:3058:bd00:ee55:f9ff:fe7b:f7ac) has joined #tryton10:17
pokoliAnyone know which is this error related to?
cedkpokoli: I do not think you can pass argument to click11:48
-!- ronaldm(c5d3d812@gateway/web/freenode/ip. has joined #tryton11:49
cedkpokoli: indeed change is valid argument11:50
cedkpokoli: did you override reset_bom?11:50
cedkpokoli: it is probably 48ca7078f8ca11:52
cedkbut does it make sense to check button access on a button_change?11:58
pokolicedk: this is the standard production module. I didn't change anything of the scenario12:02
pokoliACTION checking12:02
-!- csotelo(~csotelo@ has joined #tryton12:04
pokolicedk: for me we can skip the button access on the button_change if transaction is readonly as on on_change12:07
pokolicedk: and furthermor:, they do not modify anything on server. Their modification will be checked by ir.model* checks when saved12:08
cedkpokoli: the transaction is readonly by default see line 203 of modelview.py12:09
pokolicedk: then for me it's not needed to check access12:13
cedkpokoli: but maybe it will be good to have the button rules on it12:13
pokolicedk: I don't see why we should define a rule for something that may not be saved (as the user may discard the changes)12:15
-!- giovanni_(~giovanni@ has joined #tryton12:15
pokoliHi giovanni_ :)12:17
giovanni_been a while :(12:18
cedkpokoli: a kind of confirmation12:18
cedkpokoli: but indeed I see one interest, it is that it is called with check_access after12:20
pokolicedk: don't understand12:23
cedkpokoli: in ModelView.button func is called without _check_access12:24
cedkpokoli: but indeed I think my thoughts will be part of a larger change which will make on_change* calls checked only on the border12:27
pokolicedk: after reading the issue you created, now I understand and I agree that it will be great to have such behaviour12:34
pokolicedk: the review fixed the production scenario, thanks!12:38
-!- JosDzG(~Thunderbi@ has joined #tryton13:04
-!- mariomop(~quassel@ has joined #tryton13:07
-!- nicoe( has joined #tryton13:09
-!- smarro(~sebastian@ has joined #tryton13:34
-!- JosDzG(~Thunderbi@ has joined #tryton14:07
-!- apostatize(~visavis@unaffiliated/apostatize) has joined #tryton14:15
-!- udono( has joined #tryton14:29
-!- Timitos( has left #tryton14:59
-!- Timitos( has joined #tryton15:00
-!- udono( has joined #tryton15:19
-!- csotelo_at_work(~csotelo@ has joined #tryton16:12
-!- silwol(~silwol@ has joined #tryton16:17
-!- csotelo_at_work(~csotelo@ has joined #tryton16:42
-!- csotelo_at_work(~csotelo@ has joined #tryton17:16
-!- mariomop( has joined #tryton18:10
-!- Telesight( has joined #tryton18:30
-!- kstenger( has joined #tryton18:55
-!- niki( has joined #tryton19:02
-!- kstenger( has joined #tryton20:34
-!- cjbarnes18( has joined #tryton22:29
-!- smarro(~sebastian@ has joined #tryton22:42
-!- JanGB( has joined #tryton22:57
-!- nramirezuy( has joined #tryton23:10

Generated by 2.11.0 by Marius Gedminas - find it at!