IRC logs of #tryton for Wednesday, 2016-10-26

chat.freenode.net #tryton log beginning Wed Oct 26 00:00:01 CEST 2016
-!- JosDzG(~Thunderbi@201.175.134.46) has joined #tryton00:05
-!- robink_(~quassel@unaffilated/robink) has joined #tryton03:22
-!- Pilou(~Pilou@rogoth.ir5.eu) has joined #tryton03:25
-!- Pilou(~Pilou@pdpc/supporter/active/pilou) has joined #tryton03:25
-!- JosDzG(~Thunderbi@187.154.88.150) has joined #tryton04:51
-!- JanGB(~jan@ipservice-092-216-122-042.092.216.pools.vodafone-ip.de) has joined #tryton07:49
-!- dj_xatra(~dj_xatra@217.166.83.130) has joined #tryton07:50
-!- rpit(~rpit@2a02:908:e672:1520:56ee:75ff:fe0d:d3c7) has joined #tryton08:14
-!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton08:40
-!- mrichez(~smuxi@mail.saluc.com) has joined #tryton08:51
-!- g5pw(~g5pw@mittelab/sudo/g5pw) has joined #tryton08:58
-!- nicoe(~nicoe@2a02:a03f:3058:bd00:ee55:f9ff:fe7b:f7ac) has joined #tryton10:17
pokoliAnyone know which is this error related to? http://pastebin.com/kr1DCfc911:46
cedkpokoli: I do not think you can pass argument to click11:48
-!- ronaldm(c5d3d812@gateway/web/freenode/ip.197.211.216.18) has joined #tryton11:49
cedkpokoli: indeed change is valid argument11:50
cedkpokoli: did you override reset_bom?11:50
cedkpokoli: it is probably 48ca7078f8ca11:52
cedkbut does it make sense to check button access on a button_change?11:58
pokolicedk: this is the standard production module. I didn't change anything of the scenario12:02
pokoliACTION checking12:02
-!- csotelo(~csotelo@201.240.50.21) has joined #tryton12:04
pokolicedk: for me we can skip the button access on the button_change if transaction is readonly as on on_change12:07
pokolicedk: and furthermor:, they do not modify anything on server. Their modification will be checked by ir.model* checks when saved12:08
cedkpokoli: https://bugs.tryton.org/issue598312:08
cedkpokoli: the transaction is readonly by default see line 203 of modelview.py12:09
pokolicedk: then for me it's not needed to check access12:13
cedkpokoli: but maybe it will be good to have the button rules on it12:13
pokolicedk: I don't see why we should define a rule for something that may not be saved (as the user may discard the changes)12:15
-!- giovanni_(~giovanni@90.63.246.25) has joined #tryton12:15
giovanni_Hi12:15
pokoliHi giovanni_ :)12:17
giovanni_been a while :(12:18
cedkpokoli: a kind of confirmation12:18
cedkpokoli: but indeed I see one interest, it is that it is called with check_access after12:20
pokolicedk: don't understand12:23
cedkpokoli: in ModelView.button func is called without _check_access12:24
cedkpokoli: but indeed I think my thoughts will be part of a larger change which will make on_change* calls checked only on the border12:27
pokolicedk: after reading the issue you created, now I understand and I agree that it will be great to have such behaviour12:34
pokolicedk: the review fixed the production scenario, thanks!12:38
-!- JosDzG(~Thunderbi@187.154.88.150) has joined #tryton13:04
-!- mariomop(~quassel@186.153.92.202) has joined #tryton13:07
-!- nicoe(~nicoe@host-85-201-184-151.dynamic.voo.be) has joined #tryton13:09
-!- smarro(~sebastian@181.16.7.104) has joined #tryton13:34
-!- JosDzG(~Thunderbi@187.154.88.150) has joined #tryton14:07
-!- apostatize(~visavis@unaffiliated/apostatize) has joined #tryton14:15
-!- udono(~udono@tmo-113-172.customers.d1-online.com) has joined #tryton14:29
-!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has left #tryton14:59
-!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton15:00
-!- udono(~udono@tmo-113-172.customers.d1-online.com) has joined #tryton15:19
-!- csotelo_at_work(~csotelo@179.43.97.40) has joined #tryton16:12
-!- silwol(~silwol@80.66.37.182) has joined #tryton16:17
-!- csotelo_at_work(~csotelo@190.42.17.32) has joined #tryton16:42
-!- csotelo_at_work(~csotelo@179.43.97.40) has joined #tryton17:16
-!- mariomop(~quassel@host4.186-108-114.telecom.net.ar) has joined #tryton18:10
-!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton18:30
-!- kstenger(~karla@r167-56-250-153.dialup.adsl.anteldata.net.uy) has joined #tryton18:55
-!- niki(~niki@0x3e2c8684.mobile.telia.dk) has joined #tryton19:02
-!- kstenger(~karla@r186-55-67-251.dialup.adsl.anteldata.net.uy) has joined #tryton20:34
-!- cjbarnes18(~user@host86-158-93-69.range86-158.btcentralplus.com) has joined #tryton22:29
-!- smarro(~sebastian@201.254.25.185) has joined #tryton22:42
-!- JanGB(~jan@ipservice-092-216-122-042.092.216.pools.vodafone-ip.de) has joined #tryton22:57
-!- nramirezuy(~nramirezu@r167-62-159-111.dialup.adsl.anteldata.net.uy) has joined #tryton23:10

Generated by irclog2html.py 2.11.0 by Marius Gedminas - find it at mg.pov.lt!