IRC logs of #tryton for Friday, 2020-04-17

chat.freenode.net #tryton log beginning Fri 17 Apr 2020 12:00:01 AM CEST
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton00:04
-!- k-man_(~jason@unaffiliated/k-man) has joined #tryton01:04
-!- giesen(~ggiesen@ego.giesen.me) has joined #tryton03:04
-!- thaneor(~ldlc6@r179-24-162-135.dialup.adsl.anteldata.net.uy) has joined #tryton03:04
-!- mrichez(~Maxime@2a02:a03f:4683:d700:47e0:27a8:4efc:f0fc) has joined #tryton07:04
-!- rpit(~rpit@p200300C88F4C2B0012585E561CBA5A6D.dip0.t-ipconnect.de) has joined #tryton08:04
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton09:04
-!- josesalvador(~josesalva@170.253.36.90) has joined #tryton09:04
-!- Timitos(~kpreisler@2001:a61:400:901:762b:62ff:fe84:ed7e) has joined #tryton09:04
-!- nicoe(~nicoe@2a02:578:852a:c00:7e2a:31ff:fe5e:b25d) has joined #tryton10:04
-!- giesen(~ggiesen@ego.giesen.me) has joined #tryton11:04
semarieI just found that analytic lines has date set to move.post_date when analytic is set from rules. shouldn't be move.date instead ?11:04
semariewith that, I have expense from one fiscal year recorded in analytic in next fiscal year11:04
-!- giesen(~ggiesen@ego.giesen.me) has joined #tryton11:04
cedksemarie: I guess it was because the analytic lines are created when posting the move11:04
cedkbut this sounds more logic to record analytic at the effective date of the move11:04
semariecedk: the code explicitly use the post_date: entry.get_analytic_lines(line, line.move.post_date))11:04
semarieI opened an issue11:04
semarie(in analytic_account, line.py file, line 239)11:04
pokolisemarie: for me it makes sense to use move.date, could you please submit a patch? ;)11:04
semariepokoli: just done11:04
semariehttps://bugs.tryton.org/issue9230 + https://codereview.tryton.org/305271002/11:04
pokolisemarie: great. Thanks!!11:04
-!- mariomop(~quassel@190.193.24.15) has joined #tryton12:04
-!- rpit(~rpit@p4FFB7828.dip0.t-ipconnect.de) has joined #tryton12:04
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton13:04
-!- thaneor1(~ldlc6@r190-134-6-138.dialup.adsl.anteldata.net.uy) has joined #tryton15:04
-!- josesalvador(~josesalva@170.253.36.90) has joined #tryton15:04
semariedoes it would make sens to have a button to re-apply rules on AnalyticLines ?17:04
pokolisemarie: do you think so?17:04
pokolisemarie: what will have changed in order to re-apply the rules?17:04
semariepokoli: to be able to add rules after the fact, so MoveLine without AnalyticLines could have reconsidered17:04
cedksemarie: the rules are skipped as soon as the line has any analytic17:04
cedkalso I do not think we should try to fill the history with analytic17:04
semarieyes. but what I want to do is to have a way to add analytic on already posted moves17:04
semarie*already posted moves, where there is no analytic17:04
cedkso with analytic state as draft?17:04
cedkI would say why not.17:04
semarieI am unsure to properly understand analytic state ...17:04
semarieit would be for lines waiting in the form "analytic lines to complete"17:04
semarieACTION is unsure of the exact name in english language17:04
semarieyes, it is that "Analytic Lines to Complete"17:04
cedkyes17:04
semarieso according to the domain, it is for 'draft' state17:04
pokolisemarie: It will make sense to execute it from the list of analytic lines to complete17:04
pokolisemarie: which filters on analytic_state == 'draft'17:04
semariethanks. I will take a look at it. the complex part for me will be to have a button on the ui17:04
cedkpokoli: will you commit https://codereview.tryton.org/46471002 even if you are no more assigned?17:04
-!- josesalvador(~josesalva@170.253.36.90) has joined #tryton17:04
pokolicedk: yes, i will take care18:04
-!- thaneor(~ldlc6@r190-134-6-138.dialup.adsl.anteldata.net.uy) has joined #tryton18:04
-!- thaneor1(~ldlc6@r186-55-16-182.dialup.adsl.anteldata.net.uy) has joined #tryton19:04
-!- k-man__(~jason@unaffiliated/k-man) has joined #tryton21:04

Generated by irclog2html.py 2.16.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!