IRC logs of #tryton for Sunday, 2016-03-20 #tryton log beginning Sun Mar 20 00:00:02 CET 2016
2016-03-20 02:15 -!- shrox(shrox@nat/iiit/x-vkrwmfzpfdpabrbn) has joined #tryton
2016-03-20 02:17 -!- Zephman( has joined #tryton
2016-03-20 02:20 <shrox> cedk: kstenger: Will 'FODT support for relatorio' project will require me to work entirely with the relatorio code base? Also, will the proposal to move away from genshi affect this project?
2016-03-20 02:52 <cedk> shrox: yes, relatorio is a sub project
2016-03-20 02:53 <cedk> shrox: maybe at the end, we will convert tryton report to be fodt
2016-03-20 02:54 <cedk> shrox: but the contribution workflow is the same, except that we use this bugtracker:
2016-03-20 02:54 <shrox> cedk: Saw the bugtracker :P Looking at the documentation right now.
2016-03-20 02:55 <shrox> cedk: I cannot find where to clone the repo from. I just downloaded the tar file to have a look at the codebase
2016-03-20 02:56 <cedk> shrox:
2016-03-20 02:57 <shrox> shrox: thanks
2016-03-20 02:57 <shrox> cedk: ^
2016-03-20 02:57 <cedk> ACTION going to sleep
2016-03-20 04:05 <shrox> kstenger: Are you online? Are you fairly acquainted with the relatorio documentation?
2016-03-20 06:29 -!- awasum(~awasum@ has joined #tryton
2016-03-20 06:38 <awasum> Hello, am awasum, i will like to discuss the email notification project with a mentor. I like to do the project for Gsoc.
2016-03-20 07:40 -!- frispete( has joined #tryton
2016-03-20 08:10 -!- ccaz( has joined #tryton
2016-03-20 08:35 -!- ccaz( has left #tryton
2016-03-20 08:54 -!- kstenger( has joined #tryton
2016-03-20 09:59 -!- Telesight( has joined #tryton
2016-03-20 10:13 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton
2016-03-20 10:20 -!- shrox(shrox@nat/iiit/x-vlapnanxxnlmxgal) has joined #tryton
2016-03-20 10:25 -!- sisalp( has joined #tryton
2016-03-20 10:45 <shrox> cedk: In the relatorio documentation, the in depth example mentions this code
2016-03-20 10:45 <shrox> cedk: While the quick example mentions this -
2016-03-20 10:46 <shrox> cedk: The in depth example seems to not use the at al, the file that has the dictionary that's supposed to be used.
2016-03-20 10:47 <cedk> shrox: I don't understand
2016-03-20 10:47 <shrox> cedk: The documentation is divided into 'quick example' and 'in depth' example
2016-03-20 10:48 <cedk> shrox: could you explain what is your problem?
2016-03-20 10:49 <shrox> cedk: The first link, which is the in depth example, does not use at all (as given in the example itself)
2016-03-20 10:49 <cedk> shrox: so what is the problem?
2016-03-20 10:50 <shrox> cedk: How would the report be generated at all without using the content that needs to be generated?
2016-03-20 10:50 <cedk> shrox: I don't understand
2016-03-20 10:51 <shrox> cedk: Can you have a look at the indepth example, please? There is a which has a dictionary. The goal is to take the information from the dictionary in and render it into the template.
2016-03-20 10:52 <shrox> cedk: But the code that we use seems to be incomplete as the file is not accessed at all
2016-03-20 10:53 <shrox> cedk: This is three lines of code that's used -
2016-03-20 10:53 <cedk> shrox: if you think there is improvement to do in the doc, fill an issue with a patch at
2016-03-20 10:54 <shrox> cedk: I cannot submit a path till I figure out how it's working. :P
2016-03-20 10:54 <shrox> cedk: The documentation is old then, is it?
2016-03-20 11:33 -!- Telesight( has joined #tryton
2016-03-20 12:51 -!- shrox(shrox@nat/iiit/x-onsguvmwnidfdtrv) has joined #tryton
2016-03-20 12:54 <shrox> kstenger: Are you familiar with the relatorio code base?
2016-03-20 13:39 -!- Telesight( has left #tryton
2016-03-20 13:44 -!- meanmicio(~lfm@fsf/member/meanmicio) has joined #tryton
2016-03-20 14:21 -!- shrox(shrox@nat/iiit/x-clrglvudawnxztlz) has joined #tryton
2016-03-20 14:50 -!- toshad(uid150688@gateway/web/ has joined #tryton
2016-03-20 14:55 -!- Telesight( has joined #tryton
2016-03-20 15:06 -!- manipalsingh(0e8b5206@gateway/web/cgi-irc/ has joined #tryton
2016-03-20 15:06 -!- vivekjain(0e8b5206@gateway/web/cgi-irc/ has joined #tryton
2016-03-20 15:18 <vivekjain> tryton mein aur koi IIIT se kar raha hai pata hai?
2016-03-20 15:22 -!- prayashm(~prayashm@ has joined #tryton
2016-03-20 15:40 <prayashm> Hello, can anyone help me understand the issue 5243. I want to replicate the issue. Should I define a new models, and then make views for it?
2016-03-20 15:43 <prayashm> model*
2016-03-20 15:47 -!- shrox(shrox@nat/iiit/x-onizjorlsnpcxxgq) has joined #tryton
2016-03-20 16:02 <kstenger> prayashm: no need to create a new view, just look for any view that uses the pattern state in the bug report to see how it behaves. You can go to the definition of the model and play with the required value of the field if needed to test. But the real changes will be on the client's code. I could help you with the GTK client part.
2016-03-20 16:04 <kstenger> shrox: I know the code of relatorio, altough I am not in deep knowledge of it. If you have specific questions I could help, altough I may be unable to give you a generic idea at first.
2016-03-20 16:06 <shrox> kstenger: You're here! For the project, if I understand correctly, I will primarily have to work on creating a version of as in the relatario code. Can you confirm?
2016-03-20 16:12 <prayashm> kstenger: But this is a SAO bug. I'll just search for views having similar pattern.
2016-03-20 16:17 <kstenger> shrox: yes, basically, altough I'm unsure if you should modify or better add a new file for fodt, I'll check it a bit more and come back to you on it if cedk doesn't first :)
2016-03-20 16:18 <kstenger> prayashm: the bug doesn't state if only happens in sao, on the contrary it seems it's a problem on both clients, because the "components" defined on the bugtracker point to both of them
2016-03-20 16:18 <shrox> kstenger: Haha, sure. That can be clarified later. I just wanted to clear up which bits of the relatario code I've got to play with. It could mean either modifying directly or being inspired from, that's secondary.
2016-03-20 16:20 <shrox> kstenger: Is it just FODT that I have to worry about or even FODS, etc.? At this point I'm unsure what I'll have to do for the other formats. I do think it will use the same code though.
2016-03-20 16:26 <kstenger> shrox: hmm good question, there is no mention to fods in the wiki, I guess it could be good to add both
2016-03-20 16:26 <prayashm> kstenger: Okay. I'll explore tryton client as well. There's a problem I having. Running bin/trytond -c CONFIG, when I open http://localhost:8000/ there's only one line in the body saying "http://localhost:8000/index.html"
2016-03-20 16:27 <prayashm> kstenger: I am using virtualenv now. I am dropped and created the database again, but no luck.
2016-03-20 16:28 <prayashm> kstenger: Any idea, where the problem might be?
2016-03-20 16:28 <kstenger> prayashm: you probably miss to add the 'root' value in the web section of the config file pointing to the directory where you have sao installed
2016-03-20 16:29 <shrox> kstenger: Okay, thanks! Another question. since I am not acquainted with genshi. The function insert_directives in, it says it "adds the genshi directives, handle the images and the innerdocs.".
2016-03-20 16:30 <shrox> kstenger: By add does the function actually add them in the template, or do they mean recognize the directives that are already on the template?
2016-03-20 16:30 <prayashm> kstenger: You are awesome! I don't know how it was working earlier this morning when I cloned everything from the start.
2016-03-20 16:30 <shrox> kstenger: Here is the function for your reference
2016-03-20 16:32 <shrox> kstenger:
2016-03-20 16:32 <shrox> kstenger: Forgot to paste the link :P
2016-03-20 16:33 <kstenger> prayashm: I was dealing with that for a while and got it solved 2 days ago :p
2016-03-20 16:40 <kstenger> shrox: from the repository you can paste references to the lines, like this (I'm analising your question)
2016-03-20 16:43 -!- ovnicraft(~ovnicraft@ has joined #tryton
2016-03-20 16:43 <ovnicraft> hi i found this mirror on github, are official from tryton_org ?
2016-03-20 16:43 <ovnicraft>
2016-03-20 16:44 <kstenger> ovnicraft: yes, for what I know it is updated on a daily basis
2016-03-20 16:45 <kstenger> shrox: it is adding the requested directives from the template for what I see here
2016-03-20 16:46 <kstenger> shrox: but I'm not sure f this answers your question
2016-03-20 16:46 <ovnicraft> kstenger, great
2016-03-20 16:54 <kstenger> shrox: it does not add to the template, it is parsing the template
2016-03-20 17:05 <ovnicraft> i am lookin for run sao client, so i clone hg repo and install it
2016-03-20 17:06 <ovnicraft> but i cant find a grunt task to run it
2016-03-20 17:06 <ovnicraft> how can i run it ?
2016-03-20 17:07 <prayashm> ovnicraft: You need to clone trytond, specify root as the path of the sao repo, and then run trytond server. That's how sao runs.
2016-03-20 17:07 <prayashm> ovnicraft: Specify root and database in the config file.
2016-03-20 17:09 <ovnicraft> i cloned both repos and installed trytond deps i found this
2016-03-20 17:09 <ovnicraft> prayashm, just needed that ?
2016-03-20 17:09 <ovnicraft> i refer to documentation link
2016-03-20 17:10 <prayashm> ovnicraft: right. go on and run the trytond server with bin/trytond -c CONFIGFILE
2016-03-20 17:11 <prayashm> ovnicraft: You have added the root = /path/to/sao/repo to config file, ryt?
2016-03-20 17:13 <ovnicraft> prayashm, by now my conf is
2016-03-20 17:13 <ovnicraft> need an specific section for root ?
2016-03-20 17:14 <kstenger> ovnicraft: development version ?
2016-03-20 17:15 <kstenger> ovnicraft: if so, you have to check development docs here
2016-03-20 17:15 <ovnicraft> 3.8.4
2016-03-20 17:15 <kstenger> ah, then no
2016-03-20 17:16 <kstenger> ovnicraft: before 3.9, web section was called jsonrpc
2016-03-20 17:16 <kstenger> set the root and listen variables in the jsonrpc section
2016-03-20 17:16 <kstenger> hopefully it will work, altough i didn't try this on 3.8 yet
2016-03-20 17:17 <ovnicraft> i can switch to default branch and do it
2016-03-20 17:17 <kstenger> ovnicraft: it's the preferred version if you plan develop
2016-03-20 17:18 <ovnicraft> kstenger, python deps change from 3.8.4 to default branch ?
2016-03-20 17:18 <ovnicraft> my venv has 3.8.4 deps from nantic tasks/requirements.txt
2016-03-20 17:18 <ovnicraft> btw, my first issue is try to run tryton and sao client
2016-03-20 17:18 <kstenger> ovnicraft: I think psycopg2, it needs to be >= 2.5
2016-03-20 17:19 <kstenger> ovnicraft: I cannot tell for others
2016-03-20 17:19 <kstenger> ovnicraft: which are the issues?
2016-03-20 17:20 <ovnicraft> werkzeug dep
2016-03-20 17:20 <ovnicraft> tryton has not requirements.txt :(
2016-03-20 17:20 <kstenger> ovnicraft: ah yes, I had to install that one
2016-03-20 17:20 <prayashm> kstenger: Is there any reason for two docs instances? One at and another at
2016-03-20 17:21 <kstenger> prayashm: version
2016-03-20 17:21 <prayashm> kstenger: is for 3.8, what is the readthedocs instance for?
2016-03-20 17:22 <ovnicraft> ok now its installed
2016-03-20 17:22 <kstenger> prayashm: development version
2016-03-20 17:22 <ovnicraft> sao runs at 8000 ?
2016-03-20 17:22 <kstenger> ovnicraft: same port you set up in your config file, usually 8000
2016-03-20 17:23 <ovnicraft> 6727 139996409247488 [2016-03-20 16:21:09,563] INFO werkzeug * Running on http://localhost:8000/ (Press CTRL+C to quit)
2016-03-20 17:23 <kstenger> so yes ovnicraft
2016-03-20 17:24 <ovnicraft> kstenger, and browser render this in plain text http://localhost:8000/index.html/
2016-03-20 17:24 <kstenger> ovnicraft: show me a paste of your current config file
2016-03-20 17:25 <ovnicraft>
2016-03-20 17:25 <kstenger> ovnicraft: still on 3.8 ?
2016-03-20 17:26 <ovnicraft> now in default
2016-03-20 17:26 <kstenger> ok, so add a web section as explained in the docs, with listen and root values
2016-03-20 17:27 <kstenger> currently your root value is inside database section
2016-03-20 17:27 <kstenger> ovnicraft: ^
2016-03-20 17:28 <ovnicraft> kstenger, yay !
2016-03-20 17:29 <kstenger> :)
2016-03-20 17:30 <ovnicraft> so next step the db
2016-03-20 17:31 <kstenger> (bbiaw, lunch)
2016-03-20 17:38 -!- prayashm(~prayashm@ has joined #tryton
2016-03-20 17:48 <sisalp> hello, need an explaination about "send the report" button
2016-03-20 17:49 <sisalp> is it enough to configure smtp to make Tryton server send the mail ?
2016-03-20 17:49 <sisalp> is there a mail template somewhere ?
2016-03-20 17:51 <sisalp> and I don't understand where to indicate smtp server user/password in configuration.
2016-03-20 17:54 <sisalp> sorry, have to dig a bit, seems I already have part of the answers.
2016-03-20 17:55 -!- rpit(~rpit@2a02:908:e672:9420:56ee:75ff:fe0d:d3c7) has joined #tryton
2016-03-20 18:04 <shrox> kstenger: Thanks for the clarification!
2016-03-20 18:37 -!- rpit(~rpit@2a02:908:e672:9420:56ee:75ff:fe0d:d3c7) has joined #tryton
2016-03-20 18:46 <shrox> kstenger: The following is an import in in the trytond code
2016-03-20 18:46 <shrox> kstenger: from relatorio.templates.opendocument import Manifest, MANIFEST
2016-03-20 18:47 <shrox> kstenger: But manifest has never actually been used
2016-03-20 18:47 <shrox> kstenger: Nor has anything else from opendocument
2016-03-20 18:47 <shrox> kstenger: How is trytond then using relatorio to make reports?
2016-03-20 18:51 <shrox> kstenger:
2016-03-20 19:01 -!- prayashm(~prayashm@ has joined #tryton
2016-03-20 19:11 -!- prayashm(~prayashm@ has joined #tryton
2016-03-20 19:13 -!- sisalp( has joined #tryton
2016-03-20 19:17 <kstenger> shrox: it seems the code where Manifest and MANIFEST where used was removed (trying to figure out when and why). So you should focus on the use of relatorio.reporting I believe.
2016-03-20 19:19 -!- rpit(~rpit@2a02:908:e672:9420:56ee:75ff:fe0d:d3c7) has joined #tryton
2016-03-20 19:24 <kstenger> shrox: check "hg diff -c 5115" to understand why it was removed
2016-03-20 19:40 <prayashm> kstenger: Could you tell What are Static and Dynamic states of field?
2016-03-20 20:08 <kstenger> prayashm: give me more context pls
2016-03-20 20:09 <prayashm> kstenger: I am trying to fix the required field issue for separators.
2016-03-20 20:10 <prayashm> kstenger: I was reading through documentation, came across that fields can have a required attribute and states attribute which has a dict which can have required value (dynamic)
2016-03-20 20:11 <prayashm> kstenger: So I didn't understand the requirement of a static and dynamic states.
2016-03-20 20:27 <kstenger> ah prayashm, yes, as you can see the readonly and required fields can be passed in two ways, one is directly as a parameter (with a static value), and the other is through the states parameter (as a dynamic dictionary where you can use pyson statements [so making it dynamic])
2016-03-20 20:28 <prayashm> kstenger, pyson statements. I am yet to read that.
2016-03-20 20:29 <prayashm> kstenger, I think I could fix the issue for sao. Optimizing a bit.
2016-03-20 20:29 <kstenger> yes, well, it's a way to set the value of these parameters depending on some condition at each time, the best way (in my own experience) to understand them, is to see a lot of examples from the code
2016-03-20 20:30 <kstenger> (talking about pyson ^ )
2016-03-20 20:30 <kstenger> and usually, when you have a pyson expresion that depends on the value of another field, then you have to add it to the depends parameter
2016-03-20 20:31 <kstenger> it's a bit complex at first, but I think you don't need this for this issue at least
2016-03-20 20:32 <kstenger> if you feel confident with sao, then I can help you with gtk, remember both patches should be ready in order to be able to apply them to the repo :-)
2016-03-20 20:33 <prayashm> kstenger, the thing is I am not cent percent sure. Can I just send the sao patch for review?
2016-03-20 20:33 <kstenger> yes, and you can even get it accepted, but both should be ready to be commited to the repo
2016-03-20 20:34 <kstenger> it would be on hold until both are ok
2016-03-20 20:34 <kstenger> (I have a patch myself in this condition... but I'm just learning JS... I hope I can get it ready some day soon :)
2016-03-20 20:44 <prayashm> kstenger, Is there any document for Coding Guidelines?
2016-03-20 20:46 <kstenger> prayashm: did you check ?
2016-03-20 20:47 <prayashm> kstenger, Yep, I was reading the same page.
2016-03-20 20:47 <prayashm> kstenger, Under Submitting Codereview the first point is follow coding guidelines. I was wondering if there's any specific page for it.
2016-03-20 20:48 <kstenger> prayashm: ok, I guess you wanted some more on the coding style, but I think there is nothing on it (altough I may be wrong). Just try to follow the same style you see in the existing code. In case something does not fit it will raise up in the code review.
2016-03-20 20:49 <prayashm> kstenger, great.
2016-03-20 20:55 -!- kstenger1( has joined #tryton
2016-03-20 20:56 <kstenger> prayashm: I remembered, for python code, follow PEP8
2016-03-20 20:56 <kstenger> on javascript I have no clue
2016-03-20 20:56 <prayashm> kstenger, Thanks
2016-03-20 20:56 <kstenger> yw
2016-03-20 20:57 <prayashm> kstenger, which way do you use for codereview?
2016-03-20 20:57 <prayashm> kstenger, or hgreview?
2016-03-20 20:57 <kstenger> hgreview
2016-03-20 20:57 <kstenger> it's the best
2016-03-20 20:57 <kstenger> and I never could make work for me :D
2016-03-20 20:57 <prayashm> kstenger, I am unable to install hgreview
2016-03-20 20:57 <kstenger> it's also recomended in the guidelines
2016-03-20 20:58 <kstenger> what's the issue prayashm
2016-03-20 20:58 -!- ovnicraft(~ovnicraft@ has joined #tryton
2016-03-20 20:59 <prayashm> kstenger, pip install hgreview shows
2016-03-20 21:00 <prayashm> kstenger, and here's the pip.log
2016-03-20 21:03 <prayashm> lemme compile from source
2016-03-20 21:03 <kstenger> yes, I was going to suggest it, but it also looks like some dependency is not met, mercurial version?
2016-03-20 21:03 <kstenger> ah... review... hmm
2016-03-20 21:04 <prayashm> 3.7.2
2016-03-20 21:04 <kstenger> yea, try from source... I don't know what it's trying to do
2016-03-20 21:04 <kstenger> remember to pip uninstall it
2016-03-20 21:05 <prayashm> kstenger, installing from source worked
2016-03-20 21:05 <kstenger> btw, hgreview is probably something you want to install system wide
2016-03-20 21:06 <prayashm> kstenger, sure ... i'll do it.
2016-03-20 21:07 <prayashm> kstenger, can you recommend any fast introduction to mercurial?
2016-03-20 21:08 <kstenger> er... no... I learnt it the hard way, depending on the needs I was having at each time... you can probably easily google some tutorial, it's well documented too, and the #mercurial channel is very helping too
2016-03-20 21:10 <kstenger> do you come from git?
2016-03-20 21:10 <prayashm> kstenger, I do. :)
2016-03-20 21:10 <kstenger> then I have something for you... let me find it
2016-03-20 21:12 <kstenger> this is useful for me, altough I'm doing the opposite path, leaning git after mercurial :)
2016-03-20 21:12 <kstenger> ACTION hating git... ugh
2016-03-20 21:14 <prayashm> kstenger, Thanks a hundred times!!
2016-03-20 21:14 <kstenger> glad to help :)
2016-03-20 21:15 <prayashm> kstenger, why are you hating git?
2016-03-20 21:17 <kstenger> probably because I got too used to mercurial, and altough at first it seemed hard, later I understood it's simplicity, kind of the same happened to me with tryton (which I learnt at the same time). Now I have to use tome github repos and each thing I have to do gives me a headache :-D in particular, I don't yet understand the meaning of git branches...
2016-03-20 21:17 <kstenger> /stome/some/
2016-03-20 21:18 <kstenger> s/tome/some
2016-03-20 21:18 <kstenger> bah... :D
2016-03-20 21:18 <kstenger> feel free to give me some advice prayashm :D
2016-03-20 21:19 <prayashm> kstenger, I read this book
2016-03-20 21:19 <prayashm> kstenger, First 3 chaps are enough for most of the tasks.
2016-03-20 21:20 <kstenger> prayashm: thanks, I'll take a look :)
2016-03-20 21:20 <prayashm> kstenger, It is said that branching is the best feature of git.
2016-03-20 21:21 <kstenger> I don't know... I use hg log -G and everything makes sense to me in mercurial :)
2016-03-20 21:23 <prayashm> kstenger, are branches encouraged in hg too?
2016-03-20 21:24 <kstenger> just do hg log -G in trytond repo and you'll see, there is a branch for each version, but the meaning of branch is quite different... altough I cannot explain it because I yet dont understand the concept in gt
2016-03-20 21:24 <prayashm> I saw it.
2016-03-20 21:25 <prayashm> kstenger, there are not many branches as much as generally used in git
2016-03-20 21:26 <prayashm> kstenger, they are like this
2016-03-20 21:30 -!- xrg_( has joined #tryton
2016-03-20 21:31 <prayashm> kstenger, I uploaded the patch to codereview
2016-03-20 21:32 <prayashm> kstenger,
2016-03-20 21:33 <prayashm> kstenger, the #1 message went blank. At what stage I could have specified that?
2016-03-20 21:37 <kstenger> on the git thing, as I understand it you make a branch for each fix before it get's applied to the develop or main branch, right?
2016-03-20 21:38 <kstenger> on the patch, 1) the first "message" you see in rietveld is always blank (every time you upload a new patch set the message is blank)
2016-03-20 21:38 <prayashm> kstenger, yes ... after you are done with a branch, you can merge it with the master branch. And you can even delete the fix branch after merging.
2016-03-20 21:39 <prayashm> kstenger, oh okay then.
2016-03-20 21:39 <kstenger> 2) you have to put the description of the fix in the message parameter to hg review (if it didn't open an editor like if you were doing a commit)
2016-03-20 21:40 <kstenger> (it should actually open an editor, I'm wondering if some config might be missing for you if this didn't happen)
2016-03-20 21:40 <prayashm> kstenger, I used -m flag
2016-03-20 21:41 <prayashm> kstenger, isn't that used for passing the comment/message in a single line?
2016-03-20 21:41 <kstenger> 3) when you place this message, you put the commit message on the first line, and a longer description starting at the third line, leaving the last line for the issue number (the number in the bugtracker)
2016-03-20 21:41 <kstenger> ah, no, don't use -m and it will open the editor
2016-03-20 21:41 <kstenger> so
2016-03-20 21:42 <kstenger> 4) if you already uploaded a patch without this info, you should go to rietveld and edit the issue (you should see a link for this on your own issues)
2016-03-20 21:43 <kstenger> and the message you will put should follow the ones stated in 3)
2016-03-20 21:43 <kstenger> prayashm: tell me if something is not clear
2016-03-20 21:44 <kstenger> oh
2016-03-20 21:44 <prayashm> kstenger, I understood. Editing the issue
2016-03-20 21:44 <kstenger> 5) do not put the issue number in the commit message, no need for it as it goes below
2016-03-20 21:44 <kstenger> just explain the fix
2016-03-20 21:47 <kstenger> prayashm: did you test your patch so the label shows accordingly to each state?
2016-03-20 21:48 <prayashm> kstenger: I tested for required, not required
2016-03-20 21:48 <prayashm> kstenger: I should have checked for readonly as well?
2016-03-20 21:48 <kstenger> cool, the patch is surprising for me in my lack of js knowledge :)
2016-03-20 21:50 <kstenger> well, the patch only talk about required. You can discuss this on the bugtracker, maybe they consider it could go all together
2016-03-20 21:51 <kstenger> s/the patch/the bugtracker issue/
2016-03-20 21:52 <prayashm> kstenger, Does this mean "s/the patch/the bugtracker issue/" I should read "the bugtracker" as "the patch issue"?
2016-03-20 21:52 <kstenger> in my opinion, it should not go on this issue
2016-03-20 21:52 <prayashm> kstenger, I am new to irc too!
2016-03-20 21:53 <kstenger> no, when we use s/something/whatever/ it means a substitution (usually used in vim, so very common in opensource idiom :-)
2016-03-20 21:54 <kstenger> substitutes "something" by "whatever" in the previous sentence
2016-03-20 21:55 <prayashm> kstenger, oh okay... that's nice
2016-03-20 21:55 <kstenger> prayashm: if you look at rietveld patch now, it has a link pointing to the issue
2016-03-20 21:56 <kstenger> and in a few minutes there will be a link in the issue pointing to rietveld patch
2016-03-20 21:56 <prayashm> kstenger, yep, I noticed that.
2016-03-20 21:56 <prayashm> kstenger, btw can I delete the #3 message on the patch?
2016-03-20 21:56 <kstenger> so, wait until this link appears and add a message in the bugtracker saying you posted a new review for it
2016-03-20 21:57 <kstenger> prayashm: nah, don't worry, it's just for exchanging information during the life of the patch in rietveld
2016-03-20 21:57 <kstenger> all comments, general or in-line will appear there and be emailed to you
2016-03-20 21:57 <prayashm> kstenger, I thought the issue had to referenced in the message
2016-03-20 21:58 <prayashm> s/to/to be
2016-03-20 21:58 <kstenger> just in the first message when you submit the review
2016-03-20 22:00 <kstenger> ahh, there is something else... when you mess up the first message this happens, the bugtracker doesn't put the review number accordingly until you resend the review
2016-03-20 22:00 <prayashm> kstenger, Ohhh!
2016-03-20 22:00 <prayashm> kstenger, So first I will close the patch issue and then resend?
2016-03-20 22:00 <kstenger> so just use hg review again, and put 'repost' (or the like as the message) this just describes the patchset, so no need for more
2016-03-20 22:01 <kstenger> no need to close
2016-03-20 22:01 <prayashm> kstenger, where should I put the "repost"?
2016-03-20 22:01 <prayashm> kstenger, in the commit message
2016-03-20 22:01 <prayashm> kstenger, ?
2016-03-20 22:02 <kstenger> in this case you can just hg review -m 'repost'
2016-03-20 22:06 <kstenger> that's it prayashm :)
2016-03-20 22:06 <kstenger> now you should wait for a review, and take care of any comments you get
2016-03-20 22:07 <prayashm> kstenger, I just noticed the reviews field in the bug tracker. I could have put the codereview number and updated the bugtracker issue isn't it?
2016-03-20 22:07 <kstenger> yes :)
2016-03-20 22:08 <prayashm> kstenger, great!
2016-03-20 22:08 <kstenger> btw, dont forget to put a message regarding your new review upload in the bugtracker, nosy list get's notified for new comments but not for new review
2016-03-20 22:08 -!- acid__(~dot@ has joined #tryton
2016-03-20 22:15 <prayashm> kstenger, Just did that. Thanks a lot for helping throughout!
2016-03-20 22:21 <kstenger> you're welcome prayashm!
2016-03-20 22:41 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton
2016-03-20 22:58 -!- acid__(~dot@ has left #tryton
2016-03-20 23:11 -!- ovnicraft(~ovnicraft@ has joined #tryton

Generated by 2.17.3 by Marius Gedminas - find it at!